You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's a good way to seamlessly enable RTC for those that have the jupyter-collaboration package installed.
However I'm wondering if it would be possible to allow using both without disabling the default file browser by default.
Proposed Solution
In some situation we might want to be able to use both the default file browser from JupyterLab and the collaboration drive side by side.
Thinking this will probably be the case for JupyterLite that would still use the default file browser for storing content in the browser storage, but could use the collaboration drive for enabling RTC on a subset of documents (and keep things clearly separated).
Additional context
The text was updated successfully, but these errors were encountered:
However I'm wondering if it would be possible to allow using both without disabling the default file browser by default.
The idea of replacing the default file browser was to allow file browser extensions to work with RTC. If we create a new file browser, the extensions that modify and improve the file browser won't work with RTC. They will apply only to the default file browser.
Thinking this will probably be the case for JupyterLite that would still use the default file browser for storing content in the browser storage, but could use the collaboration drive for enabling RTC on a subset of documents (and keep things clearly separated).
I already did some experiments with JupyterLite here. As shown by @bollwyvl with the JupyterLab-webrtc-docprovider, JupyterLite is a particular case for RTC, and this extension (Jupyter-collaboration) won't work.
My idea was to modify JupyterLab-webrtc-docprovider to create an extension that provides a new default file browser with a collaborative IDrive based on WebRTC. This way, JupyterLite will benefit from file browser extensions and Jupyter-collaboration.
Conversely, we can reuse the @jupyter/collaboration package in JupyterLab-webrtc-docprovider to bring the collaborative features to JupyterLite as well.
Problem
Currently it looks like the
collaboration-extension
disables the default file browser here:https://github.com/jupyterlab/jupyter_collaboration/blob/d8481ce01934a671e5da049f31062bbbb6bccd56/packages/collaboration-extension/package.json#L91-L93
And provides its own
IDefaultFileBrowser
here:https://github.com/jupyterlab/jupyter_collaboration/blob/d8481ce01934a671e5da049f31062bbbb6bccd56/packages/collaboration-extension/src/filebrowser.ts#L29
It's a good way to seamlessly enable RTC for those that have the
jupyter-collaboration
package installed.However I'm wondering if it would be possible to allow using both without disabling the default file browser by default.
Proposed Solution
In some situation we might want to be able to use both the default file browser from JupyterLab and the collaboration drive side by side.
Thinking this will probably be the case for JupyterLite that would still use the default file browser for storing content in the browser storage, but could use the collaboration drive for enabling RTC on a subset of documents (and keep things clearly separated).
Additional context
The text was updated successfully, but these errors were encountered: