Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating jtpio/jupyterlab-extension-examples to jupyterlab/extension-examples #44

Closed
jtpio opened this issue Mar 11, 2020 · 9 comments
Closed

Comments

@jtpio
Copy link
Member

jtpio commented Mar 11, 2020

Together with @echarles and @fcollonval, we have taken over the work initiated by @MMesch on building a set of extension examples for JupyterLab. They are currently living in the following repository:

https://github.com/jtpio/jupyterlab-extension-examples

As mentioned in the last developer call, we have been making significant progress recently, and we think it's now in a good shape to consider migrating it over here. Also the recent 2.0 release makes it a good time to bring that up, as the community will be looking into updating existing extensions, or creating new ones.

Even though we haven't really publicly communicated about it yet, it has already been proven useful to some developers:

We think this resource could be made even more visible by migrating the repository over to the jupyterlab organization. Links and references can then be added to the documentation to point to these extra materials.

This set of extensions is not meant to replace the JupyterLab documentation. Instead it provides an alternative way to learn how to make an extension: by running example code and trial and error.

Criteria for official subprojects

All criteria might not apply for this particular repository, but since it is mentioned in #12 we can go over the list here:

Have an active developer community that offers a sustainable model for future development.

As of today (2020/03/11), there has been 4 contributors to the project. 3 of them are active in the JupyterLab ecosystem and have authored several JupyterLab extensions.

Have an active user community.

The targeted user community is identical to the one targeted by the JupyterLab documentation and the apod tutorial.

Use solid software engineering with documentation and tests hosted with appropriate technologies (Read The Docs and Travis are examples of technologies that can be used).

All examples are documented, linted, formatted, and CI ensures the configs are identical for all examples. CI also checks the embedded code snippets are up-to-date. See https://github.com/jtpio/jupyterlab-extension-examples/pull/71/checks as an example.

All examples follow the structure of the TypeScript Cookiecutter, and the Server Extension TypeScript Cookiecutter for the server extension example.

PRs are reviewed by at least one other person.

Maintenance wise, the procedure to update the examples to support the latest JupyterLab version is similar as the one used to update the cookiecutter repositories and the extension tutorial.

Demonstrate continued growth and development.

There is a growth in interest for this kind of resource and documentation issues in the JupyterLab repo.

Integrate well with other official Subprojects

This complements the existing JupyterLab documentation.

Be developed according to the Jupyter governance and contribution model that is documented here

The contributing guide can easily be extended to make these points more visible.

Have a well-defined scope.

See https://github.com/jtpio/jupyterlab-extension-examples#tldr.

Be packaged using appropriate technologies such as pip, conda, npm, bower, docker, etc.

The examples are not packaged and released (out of scope).

References

@afshin
Copy link
Member

afshin commented Mar 11, 2020

I think this is a great idea 👍

https://github.com/jupyterlab/extension-examples

@jasongrout
Copy link
Contributor

We think this resource could be made even more visible by migrating the repository over to the jupyterlab organization. Links and references can then be added to the documentation to point to these extra materials.

Definitely +1 from me!

@saulshanabrook
Copy link
Member

So excited about this! Thank you ❤️

@ian-r-rose
Copy link
Member

Big 👍

@blink1073
Copy link
Contributor

Thanks for the hard work and the thoughtful proposal @jtpio! 👍

@jasongrout
Copy link
Contributor

It looks like so far the sentiment is overwhelmingly positive (8 responses). How about we leave this open one more day for anyone else to flag any concerns before moving forward with it?

@jtpio
Copy link
Member Author

jtpio commented Mar 13, 2020

Thanks everyone for the positive feedback!

Let me know when it's time to move forward with it.

@jasongrout
Copy link
Contributor

No objections have been voiced. I think it's time to move forward. Do you want to work with Sylvain to transfer the repo over? I can help tomorrow if you want as well.

@jasongrout
Copy link
Contributor

This is done now: https://github.com/jupyterlab/extension-examples/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants