Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore does not work for file extensions #81

Open
krassowski opened this issue Jul 10, 2021 · 1 comment
Open

Ignore does not work for file extensions #81

krassowski opened this issue Jul 10, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@krassowski
Copy link
Collaborator

To reproduce:

  1. Create a markdown cell with text: "test.csv"
  2. See csv highlighted as an unknown word
  3. Try to ignore it from context menu
  4. See that it gets added to ignore list as ".csv" but it does not get ignored after all
@ocordes
Copy link
Collaborator

ocordes commented Jul 13, 2021

Okay, I've checked this, there are two issues:

  • .csv is added but only csv is highlighted, so we should only add words without leading/ending punctuations
  • after any word is added we should trigger a recheck, then the word is correctly ignored.
  • maybe it is wise to provide some default ignores which includes all file extensions ...

@krassowski krassowski added the bug Something isn't working label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants