Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not check when there is another language #142

Open
Firestar-Reimu opened this issue Apr 26, 2024 · 7 comments
Open

do not check when there is another language #142

Firestar-Reimu opened this issue Apr 26, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@Firestar-Reimu
Copy link

I use Chinese with English, so that all the Chinese characters will be marked as wrong spelling

But I cannot find where to turn off spell checking

As for now no CJK dictionary is supported

You can disable checking when CJK characters are detected.

@Firestar-Reimu Firestar-Reimu added the enhancement New feature or request label Apr 26, 2024
@krassowski
Copy link
Collaborator

As for now no CJK dictionary is supported

Did you try with a dictionary and saw it fail, or did you assume it is not supported because it is not shipped by default?

For example https://github.com/LibreOffice/dictionaries/tree/master/ko_KR should work. If it does not we should fix it in the extension. See https://github.com/jupyterlab-contrib/spellchecker?tab=readme-ov-file#adding-dictionaries---example for instructions on how to add dictionaries.

@Firestar-Reimu
Copy link
Author

Firestar-Reimu commented May 9, 2024

Or maybe spellcheck should not check code blocks and especially comments in code blocks.

@krassowski
Copy link
Collaborator

Or maybe spellcheck should not check code blocks and especially comments in code blocks.

You can disable checking spelling in comments in settings.

@Firestar-Reimu
Copy link
Author

图片
I turned it off but it still check my comments

@krassowski
Copy link
Collaborator

Does it persist after refreshing/reloading page?

@Firestar-Reimu
Copy link
Author

It persist after refreshing/reloading page/restaring kernel/shut down jupyterlab and re-open

@AllanYCG
Copy link

AllanYCG commented Jan 2, 2025

Hi @Firestar-Reimu, Have you found a way to fix the incorrect spell-checking issue for multi-language coding? I’ve been facing the same problem when working with multiple languages. I also noticed that I can’t disable this extension. Let me know if you’ve found a solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants