Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging commonhealth-cloud-storage-client on conda-forge #14

Open
1 of 2 tasks
minrk opened this issue Apr 11, 2024 · 2 comments
Open
1 of 2 tasks

packaging commonhealth-cloud-storage-client on conda-forge #14

minrk opened this issue Apr 11, 2024 · 2 comments
Assignees

Comments

@minrk
Copy link
Member

minrk commented Apr 11, 2024

@fperez asked to package the common health cloud Python client to be on conda-forge

Current impediments:

  • strict version pinning in the package. See Python packaging recommendations, but it's usually not a good idea to pin exact dependencies in a package, as that causes conflicts with other packages. Pinning is usually a good idea when building docker images, etc., but that's best done in an external requirements.txt managed through something like pip-compile, dependabot, etc.
  • tink is a dependency that is also not yet on conda-forge (I can manage, it'll just take a bit because it uses bazel, a build system I'm not familiar with)

cc @surfdoc for the package pinning

This is not pressing, and can be done comfortably after pre-MVP. It does not block anything. Fixing the pinning would help a bit for the pre-MVP, but can be worked around without too much trouble for now.

@minrk minrk self-assigned this Apr 11, 2024
@minrk
Copy link
Member Author

minrk commented Apr 12, 2024

version pinning is addressed in 1.0.5, tink will require more time

@minrk
Copy link
Member Author

minrk commented Jul 1, 2024

The new MVP architecture removes cryptography responsibilities from the partner, which I assume will remove tink from the dependency list. That should make packaging the next version of the client on conda-forge easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant