Skip to content

Commit f3df01e

Browse files
authored
Merge pull request #3330 from takluyver/no-gettext-builtin
Don't install gettext into builtins
2 parents 64f02d8 + 83fd9bb commit f3df01e

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

docs/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ help:
5151

5252
clean:
5353
rm -rf $(BUILDDIR)/*
54-
rm -rf config.rst
54+
rm -rf source/config.rst
5555

5656
html: source/config.rst
5757
$(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(BUILDDIR)/html

docs/doc-requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
sphinx>=1.3.6
22
sphinx-rtd-theme
3-
nbsphinx==0.2.14
3+
nbsphinx

docs/source/changelog.rst

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ For more detailed information, see
1313
upgrade to the latest release.
1414

1515
.. we push for pip 9+ or it will break for Python 2 users when IPython 6 is out.
16+
1617
We strongly recommend that you upgrade to version 9+ of pip before upgrading ``notebook``.
1718

1819
.. tip::

notebook/notebookapp.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -832,9 +832,11 @@ def _token_changed(self, change):
832832
`new` argument passed to the standard library method `webbrowser.open`.
833833
The behaviour is not guaranteed, but depends on browser support. Valid
834834
values are:
835-
2 opens a new tab,
836-
1 opens a new window,
837-
0 opens in an existing window.
835+
836+
- 2 opens a new tab,
837+
- 1 opens a new window,
838+
- 0 opens in an existing window.
839+
838840
See the `webbrowser.open` documentation for details.
839841
"""))
840842

notebook/transutils.py

-1
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,4 @@
1010
# Set up message catalog access
1111
base_dir = os.path.realpath(os.path.join(__file__, '..', '..'))
1212
trans = gettext.translation('notebook', localedir=os.path.join(base_dir, 'notebook/i18n'), fallback=True)
13-
trans.install()
1413
_ = trans.gettext

0 commit comments

Comments
 (0)