Simplification of `model_exists?` in the serializable generator #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jgomo3 opened this issue Apr 11, 2025 · 0 comments

jgomo3 commented Apr 11, 2025 •

edited

Loading

jsonapi-rails/lib/generators/jsonapi/serializable/serializable_generator.rb

Line 18 in 2e1b5b1

def model_exists?

That method could be written:

def model_exists?
  Rails.application.eager_load!
  ApplicationRecord.descendants.any? { _1.name == class_name }
end

Instead of:

def model_exists?
  Rails.application.eager_load!
  models = ApplicationRecord.descendants.map(&:name)
  !!models.find { |model_name| model_name == class_name }
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment