Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: FAQ Accordion Tabs Do Not Close on Repeated Clicks #1290

Open
Karan-Palan opened this issue Jan 11, 2025 · 2 comments
Open

🐛 Bug: FAQ Accordion Tabs Do Not Close on Repeated Clicks #1290

Karan-Palan opened this issue Jan 11, 2025 · 2 comments
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage.

Comments

@Karan-Palan
Copy link
Contributor

Describe the bug

In the FAQ section, when a question is expanded by clicking on its tab header, clicking on the same header again does not toggle it closed. This behavior forces the user to click the "x" icon to close the tab, creating an inconsistent experience.

Steps To Reproduce

  1. Go to the FAQ section on the JSON Schema website.
  2. Click on the "+" icon of any question to expand its content, then click on 'x' icon, it will close
  3. Click on the same tab header again.
  4. Observe that the tab remains open instead of toggling closed.

Expected Behavior

Clicking on the tab header of an expanded FAQ question should close the accordion, allowing users to toggle it on and off by clicking the same header.

Screenshots

WhatsApp.Video.2025-01-11.at.14.54.47.mp4

Device Information [optional]

- OS: Windows 11 (as recording shows mouse cursor)
- Browser: Browser
- version:

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

@Karan-Palan Karan-Palan added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Jan 11, 2025
@Utkarsh-123github
Copy link
Contributor

@Karan-Palan I think this isn't an issue to be noticed because buttons are provided with some reason and functionality to do the required action.

@Karan-Palan
Copy link
Contributor Author

@Utkarsh-123github Thank you for sharing your perspective. While I agree that buttons are provided for specific functionality, the issue here is regarding the user experience and consistency. Accordions are generally expected to toggle open and closed when clicking on the same header, which is a standard behavior across many interfaces.

Since the accordion opens on clicking on it, it should close the expanded section too by clicking. This is my POV, will wait for the maintainers and other community members views on it before proceeding with Pull requests on any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage.
Projects
None yet
Development

No branches or pull requests

2 participants