Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: URL color on homepage in dark-mode #1286

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Conversation

Adi-204
Copy link
Contributor

@Adi-204 Adi-204 commented Jan 10, 2025

What kind of change does this PR introduce?
This PR updates the color of the URL displayed on the homepage in dark mode for improved visibility.

Issue Number:

Screenshots/videos:
image

Summary
In dark mode, the URL on the homepage was underlined in black, making it difficult for users to identify. This PR changes the underline color to white, ensuring better visibility and enhancing usability.

Does this PR introduce a breaking change?
No

@Adi-204 Adi-204 requested a review from a team as a code owner January 10, 2025 15:48
Copy link

github-actions bot commented Jan 10, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 0bd0c42

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4fe7488) to head (0bd0c42).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1286   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjagm
Copy link
Collaborator

benjagm commented Jan 18, 2025

I can't see the changes in the PR. Can you please confirm the features/fixes you added to the PR?

@Adi-204
Copy link
Contributor Author

Adi-204 commented Jan 18, 2025

image

@benjagm Added dark:border-white in css for dark mode. It seems like a github bug maybe try to reload page.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit ee9538b into json-schema-org:main Jan 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Links on Home page harder to guess in Dark Mode
2 participants