Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Remove Next.js build cache from preview.yml. #1178

Closed
aialok opened this issue Dec 18, 2024 · 6 comments · Fixed by #1185
Closed

🐛 Bug: Remove Next.js build cache from preview.yml. #1178

aialok opened this issue Dec 18, 2024 · 6 comments · Fixed by #1185
Assignees
@saurabhraghuvanshii
Labels
🐛 Bug Indicates that the issue is a bug or defect. Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@aialok
Copy link
Member

aialok commented Dec 18, 2024

Describe the bug

  • We are facing an issue with the Next.js build cache, which we are using for preview deployments. Due to this, CSS changes are not being updated as expected, and the older cache from the previous builds is causing the problem.

  • Removing the cache step will fix the issue.

Discussion : https://json-schema.slack.com/archives/C8C4UBXDF/p1734423225071989?thread_ts=1734410032.558099&cid=C8C4UBXDF

Steps To Reproduce

  1. Create a PR.
  2. After that, push a commit to the PR with the CSS changes.

Expected Behavior

  • It should work as expected.

Screenshots

No response

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

Yes
@aialok aialok added 🐛 Bug Indicates that the issue is a bug or defect. Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Triage This is the initial status for an issue that requires triage. labels Dec 18, 2024
@saurabhraghuvanshii
Copy link
Contributor

@aialok i can work on this. can you assign to me

@aialok
Copy link
Member Author

aialok commented Dec 18, 2024

sure go ahead @saurabhraghuvanshii.

@DhairyaMajmudar DhairyaMajmudar added Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Triage This is the initial status for an issue that requires triage. labels Dec 19, 2024
@saurabhraghuvanshii
Copy link
Contributor

saurabhraghuvanshii commented Dec 19, 2024 •
edited
Loading

@aialok why docker is not working I tried every thing it failed to create image . but yarn dev work

@aialok
Copy link
Member Author

aialok commented Dec 19, 2024

@aialok why docker is not working I tried every thing it failed to create image . but yarn dev work

@DhairyaMajmudar can you please check docker thing.

You can easily setup using yarn things.

This was referenced Dec 19, 2024
Closed
Closed
@saurabhraghuvanshii
Copy link
Contributor

@aialok review pr . If changes more to done. I will do

@saurabhraghuvanshii saurabhraghuvanshii mentioned this issue Dec 19, 2024
Merged
@saurabhraghuvanshii
Copy link
Contributor

solves branch issue therefore closed prev pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saurabhraghuvanshii saurabhraghuvanshii

Labels
🐛 Bug Indicates that the issue is a bug or defect. Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
Website Contributor Board
Status: No status
Milestone
No milestone
3 participants
@aialok @DhairyaMajmudar @saurabhraghuvanshii