-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug: Social media links Ambassadors in "Become a JSON Schema Ambassador" #1161
Comments
@Pavankumar07s, I found an issue with Esther Okafor's social links and Ege Korkan's Mastodon link in the other cards. All the other social links for the ambassadors are working well. |
@officeneerajsaini correct |
@benjagm @DhairyaMajmudar shall i start working on this? |
Sure!! looking forward for your PR |
Alright @DhairyaMajmudar |
issue will be resolved after merging json-schema-org/community#843 and #1173 |
Alright @DhairyaMajmudar 👍 This will also be resolved. |
LGTM ✅✨ |
Describe the bug
There is an issue with some ambassador card components where certain ambassador links redirect to incorrect URLs. The problem arises because the JSON file containing the ambassador information includes a mix of full URLs for social links and usernames.
In the ambassador card component, there is a formatting feature designed to standardize the URLs, but it is not effectively handling the inconsistency in the data. For example:
If the JSON contains only a username (e.g., "username": "example"), the component should prepend the base URL (e.g., https://twitter.com/) to construct the full link.
If the JSON already contains the full URL (e.g., "url": "https://twitter.com/example"), the component should use it directly without modification.
Steps To Reproduce
1.Go to the page where the ambassador cards are displayed.
2.Click on an ambassador's social link (e.g., Twitter, GitHub).
3.Scroll down to inspect other ambassador cards and try clicking their links.
4.Observe that some links redirect to incorrect URLs or fail to open properly.
Expected Behavior
All social links should redirect to the correct pages based on the provided information in the JSON file. Links should work regardless of whether they are full URLs or usernames.
Screenshots
Device Information [optional]
Are you working on this issue?
Yes
Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)
Yes
The text was updated successfully, but these errors were encountered: