Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Social media links Ambassadors in "Become a JSON Schema Ambassador" #1161

Closed
Pavankumar07s opened this issue Dec 14, 2024 · 8 comments · Fixed by json-schema-org/community#843
Assignees
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@Pavankumar07s
Copy link
Contributor

Describe the bug

There is an issue with some ambassador card components where certain ambassador links redirect to incorrect URLs. The problem arises because the JSON file containing the ambassador information includes a mix of full URLs for social links and usernames.

In the ambassador card component, there is a formatting feature designed to standardize the URLs, but it is not effectively handling the inconsistency in the data. For example:

If the JSON contains only a username (e.g., "username": "example"), the component should prepend the base URL (e.g., https://twitter.com/) to construct the full link.
If the JSON already contains the full URL (e.g., "url": "https://twitter.com/example"), the component should use it directly without modification.

Steps To Reproduce

1.Go to the page where the ambassador cards are displayed.
2.Click on an ambassador's social link (e.g., Twitter, GitHub).
3.Scroll down to inspect other ambassador cards and try clicking their links.
4.Observe that some links redirect to incorrect URLs or fail to open properly.

Expected Behavior

All social links should redirect to the correct pages based on the provided information in the JSON file. Links should work regardless of whether they are full URLs or usernames.

Screenshots

Screenshot from 2024-12-14 11-37-29

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

Yes

@Pavankumar07s Pavankumar07s added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Dec 14, 2024
@officeneerajsaini
Copy link
Contributor

@Pavankumar07s, I found an issue with Esther Okafor's social links and Ege Korkan's Mastodon link in the other cards. All the other social links for the ambassadors are working well.

@Pavankumar07s
Copy link
Contributor Author

@officeneerajsaini correct

@Pavankumar07s
Copy link
Contributor Author

@benjagm @DhairyaMajmudar shall i start working on this?

@DhairyaMajmudar
Copy link
Member

Sure!! looking forward for your PR

@DhairyaMajmudar DhairyaMajmudar added Status: In Progress This issue is being worked on, and has someone assigned. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Triage This is the initial status for an issue that requires triage. labels Dec 14, 2024
@Pavankumar07s
Copy link
Contributor Author

Alright @DhairyaMajmudar

@DhairyaMajmudar
Copy link
Member

issue will be resolved after merging json-schema-org/community#843 and #1173

@Pavankumar07s
Copy link
Contributor Author

Pavankumar07s commented Dec 17, 2024

Alright @DhairyaMajmudar 👍 This will also be resolved.

@officeneerajsaini
Copy link
Contributor

LGTM ✅✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants