Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: "Used by" companies don't have linked pages #1155

Closed
IyaadArshad opened this issue Dec 9, 2024 · 7 comments
Closed

🐛 Bug: "Used by" companies don't have linked pages #1155

IyaadArshad opened this issue Dec 9, 2024 · 7 comments
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage.

Comments

@IyaadArshad
Copy link
Contributor

Describe the bug

When clicking on the logos of the companies using JSON schema on the homepage, nothing happens, it may be better to link their websites on the home page and make it so that it opens on a new tab

Steps To Reproduce

  1. Go to https://json-schema.org/
  2. Look at the section starting "Build more"
  3. Try and click on the logo of any company using JSON Schema

Expected Behavior

In a new tab, the website of the company with the matching logo should open up

Screenshots

image

Device Information [optional]

- OS: Arch Linux x86_64
- Browser: firefox
- version: 133.0 (64-bit)

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

@IyaadArshad IyaadArshad added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Dec 9, 2024
@IyaadArshad
Copy link
Contributor Author

Note: will be using index.page.tsx from #1154 pull request to avoid merge conflicts when merging that pr

@IyaadArshad
Copy link
Contributor Author

Note: Merge #1154 before merging this one

@DarhkVoyd
Copy link
Member

Hey, IMO, the suggested behavior for the Used by logos is not desired.

@IyaadArshad
Copy link
Contributor Author

probably...
just felt like it would be a nice thing to have though :)

@benjagm
Copy link
Collaborator

benjagm commented Dec 20, 2024

Hi @IyaadArshad . This was done on purpose, trying to drive traffic to the adopters/landscape link. Let's leave this way for now. Thanks a lot for the idea.

@benjagm benjagm closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2024
@benjagm
Copy link
Collaborator

benjagm commented Dec 27, 2024

Closed as not planned.

@IyaadArshad
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants