Skip to content

Update spec to require implementations to raise an error if it encounters a dialect it doesn't understand #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gregsdennis opened this issue Oct 26, 2022 · 3 comments

Comments

@gregsdennis
Copy link
Member

gregsdennis commented Oct 26, 2022

Similarly to encountering unknown keywords, implementations should raise an error for unknown dialects.

@handrews
Copy link
Contributor

This needs an ADR, or possibly needs to be delayed until we figure out bootstrapping more clearly. Currently, we only error out on vocabularies, not dialects, and my sense is that the granularity of these concepts is in flux. We should figure out what the actual granularity of control is, and where that control is located, before trying to set the requirements in the spec.

@jdesrosiers
Copy link
Member

I think the way I used the term "dialect" might have led to some misunderstanding of the purpose of this issue. What I meant was that the implementation must raise an error if it doesn't fully understand what set of keywords are part of the dialect. That should be a concept independent of the details of bootstrapping and the vocabulary system.

I don't remember exactly what the spec currently says about this kind of thing, but I imagine that most if not all of it is already covered. However, my guess is that it's currently written in a way that is coupled to the vocabulary system and should probably be rewritten in a way that's more generic so we don't need to change the wording as the vocabulary system evolves.

@gregsdennis
Copy link
Member Author

This needs to be a consideration for whatever vocabularies ends up being. See #1510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants