Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken tests for Node@8 and Node@9 #50

Closed
carpasse opened this issue Mar 27, 2024 · 1 comment
Closed

Broken tests for Node@8 and Node@9 #50

carpasse opened this issue Mar 27, 2024 · 1 comment

Comments

@carpasse
Copy link
Contributor

Seems like the current master branch have some broken tests when running Node@8 and Node@9. @UlisesGascon noticed that when running my changes for PR jshttp/mime-db#316

I can not provide a failed build because the workflow is waiting for approval
Screenshot 2024-03-27 at 17 35 45
But I can see the ci-test action failing in my forked repo
https://github.com/carpasse/on-finished/actions/runs/8433556449
@carpasse
Copy link
Contributor Author

Sorry I meant to publish this issue on https://github.com/jshttp/on-finished

@UlisesGascon UlisesGascon transferred this issue from jshttp/cookie Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carpasse