From 2e1eea438b676a01982835b1501fcbff10f03e62 Mon Sep 17 00:00:00 2001 From: js07 <19861096+js07@users.noreply.github.com> Date: Mon, 4 Mar 2024 16:49:51 -0500 Subject: [PATCH 1/5] Only run the necessary actions on /docs changes - Move pull request checks for components to a separate workflow that runs on /components changes - Limit publish-components workflow runs to only on /components changes - Limit publish-marketplace-content workflow runs to only on /components changes - Change the publish-packages workflow to also run on pull-requests, excluding /docs changes. When running on pull-requests, do a dry run of publishing packages. --- .github/workflows/components-pr.yaml | 211 ++++++++++++++++ .github/workflows/publish-components.yaml | 2 + .../publish-marketplace-content.yaml | 2 + .github/workflows/publish-packages.yaml | 29 ++- .github/workflows/pull-request-checks.yaml | 234 ------------------ 5 files changed, 243 insertions(+), 235 deletions(-) create mode 100644 .github/workflows/components-pr.yaml diff --git a/.github/workflows/components-pr.yaml b/.github/workflows/components-pr.yaml new file mode 100644 index 0000000000000..1ce64733d3495 --- /dev/null +++ b/.github/workflows/components-pr.yaml @@ -0,0 +1,211 @@ +# TODO combine this with publish-components.yml +name: Components Checks + +on: + pull_request: + branches: + - master + paths: + - 'components/**' + +jobs: + check_version: + name: Ensure component commits modify component versions + runs-on: ubuntu-latest + + permissions: + contents: write + pull-requests: write + + steps: + - uses: actions/checkout@v4.1.1 + name: Checkout repo + with: + token: ${{ secrets.GITHUB_TOKEN }} + repository: ${{ github.event.pull_request.head.repo.full_name }} + ref: ${{ github.event.pull_request.head.ref }} + # See https://github.com/actions/checkout#checkout-v2 + # This will be slow. The intent is to fetch all commits + # since the merge-base (the commit where we branched off) + # so we can check the git diff against all changed files. + # By default, the checkout action only returns the last commit, + # There's no native way to do this in the checkout action, so + # we have to fetch the entire history. See + # https://github.com/actions/checkout/issues/266#issuecomment-638346893 + fetch-depth: 0 + - uses: jitterbit/get-changed-files@v1 + id: changed_files + name: Get changed files + with: + format: json + - name: Check git diff for version changes + uses: ./.github/actions/git-diff-on-components + with: + all_files: ${{ steps.changed_files.outputs.all }} + base_commit: ${{ github.event.pull_request.base.sha }} + head_commit: ${{ github.event.pull_request.head.sha }} + - uses: stefanzweifel/git-auto-commit-action@v5 + with: + commit_message: Automatically updating actions and sources versions + commit_options: '--no-verify' + # commit_user_name: Pipedream [Bot] + # commit_user_email: pipedream@pipedream.com + # commit_author: Pipedream [Bot] + push_options: '--force' + + verify-typescript-components: + name: Verify TypeScript components + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v4.1.1 + - uses: pnpm/action-setup@v3.0.0 + with: + version: 7.33.6 + - name: Get pnpm store directory + id: pnpm-cache + run: | + echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" + - uses: actions/cache@v4 + name: Setup pnpm cache + with: + path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} + key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} + restore-keys: | + ${{ runner.os }}-pnpm-store- + - name: Setup Node Env + uses: actions/setup-node@v4.0.2 + with: + node-version: 18 + registry-url: https://registry.npmjs.org/ + cache: 'pnpm' + - name: Install Dependencies + run: pnpm install -r + - name: Compile TypeScript + id: compile + run: npm run build > files.txt + - name: Get Changed Files + id: files + uses: jitterbit/get-changed-files@v1 + with: + format: 'csv' + - name: Check For Compiled TypeScript Files + run: | + IFS=$'\n' + # Remove initial tsc output + output_files=$(cat files.txt | sed 1,3d) + declare -a ERRORS + declare -a SKIPPED + mapfile -d ',' -t added_modified_renamed_files < <(printf '%s,%s' '${{ steps.files.outputs.added_modified }}' '${{ steps.files.outputs.renamed }}') + for added_modified_file in "${added_modified_renamed_files[@]}"; + do + echo "Checking if $added_modified_file is a publishable ts file" + if [[ $added_modified_file == components/* ]] && [[ $added_modified_file == *.ts ]] && [[ $added_modified_file != *.app.ts ]] \ + && [[ $added_modified_file != */common*.ts ]] && [[ $added_modified_file != */common/* ]] + then + # XXX This is a hacky way to publish only TS components with changes. If a changed + # file "path-a/path-b/c.ts" has a corresponding compiled output file + # "path-a/dist/path-b/c.mjs", attempt to publish the output `.mjs` file. + changed_output_file="" + for f in $output_files; # check each output file for a match + do + # Replaces /dist/path/filename.mjs with /path/filename.ts + maybe_source_file=$(echo "$f" | sed 's/\/dist\//\//;s/.mjs/\.ts/') + if [[ ${maybe_source_file} == **/${added_modified_file} ]] + then + changed_output_file=${f} + break + fi + done + if [[ $changed_output_file == "" ]] + then + ERROR_MESSAGE="cannot find an output .mjs file with ${added_modified_file}" + echo $ERROR_MESSAGE + ERRORS+=("*${ERROR_MESSAGE}") + fi + else + echo "$added_modified_file will not be added to the registry" + SKIPPED+=("*$added_modified_file") + fi + done + if [[ ${#SKIPPED[@]} -ne 0 ]]; then + echo "the following files were skipped:" + printf '%s\n' "${SKIPPED[@]}" + fi + if [[ ${#ERRORS[@]} -ne 0 ]]; then + echo "the following files generated errors:" + printf '%s\n' "${ERRORS[@]}" + echo "Please check if the components above were successfully compiled" + echo "More information here: https://pipedream.com/docs/components/typescript/#developing-typescript-components-in-the-pipedreamhq-pipedream-registry" + exit 1 + fi + unset IFS + + publish-typescript-components-dry-run: + name: Publish TypeScript components + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v4.1.1 + - uses: pnpm/action-setup@v3.0.0 + with: + version: 7.33.6 + - name: Get pnpm store directory + id: pnpm-cache + run: | + echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" + - uses: actions/cache@v4 + name: Setup pnpm cache + with: + path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} + key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} + restore-keys: | + ${{ runner.os }}-pnpm-store- + - name: Setup Node Env + uses: actions/setup-node@v4.0.2 + with: + node-version: 18 + registry-url: https://registry.npmjs.org/ + cache: 'pnpm' + - name: Install Dependencies + run: pnpm install -r + - name: Compile TypeScript + id: compile + run: npm run build > files.txt + - name: Get Changed Files + id: files + uses: jitterbit/get-changed-files@v1 + with: + format: 'csv' + - name: Publish TypeScript components (dry run) + shell: bash {0} # don't fast fail + run: | + IFS=$'\n' + mapfile -d ',' -t added_modified_renamed_files < <(printf '%s,%s' '${{ steps.files.outputs.added_modified }}' '${{ steps.files.outputs.renamed }}') + # Remove initial tsc output + output_files=$(cat files.txt | sed 1,3d) + echo "The following files will be published on merge:" + for added_modified_file in "${added_modified_renamed_files[@]}"; + do + # starts with components, ends with .ts and not app.ts, doesn't end with /common*.ts, + # and doesn't follow */common/ + if [[ $added_modified_file == components/* ]] && [[ $added_modified_file == *.ts ]] && [[ $added_modified_file != *.app.ts ]] \ + && [[ $added_modified_file != */common*.ts ]] && [[ $added_modified_file != */common/* ]] + then + # XXX This is a hacky way to publish only TS components with changes. If a changed + # file "path-a/path-b/c.ts" has a corresponding compiled output file + # "path-a/dist/path-b/c.mjs", attempt to publish the output `.mjs` file. + for f in $output_files; + do + # Replaces /dist/path/filename.mjs with /path/filename.ts + maybe_source_file=$(echo "$f" | sed 's/\/dist\//\//;s/.mjs/\.ts/') + if [[ ${maybe_source_file} == **/${added_modified_file} ]] + then + echo "$f" + fi + done + fi + done + unset IFS diff --git a/.github/workflows/publish-components.yaml b/.github/workflows/publish-components.yaml index 4d655538222ee..e47f582007fcd 100644 --- a/.github/workflows/publish-components.yaml +++ b/.github/workflows/publish-components.yaml @@ -2,6 +2,8 @@ on: push: branches: - master + paths: + - 'components/**' jobs: publish-components: diff --git a/.github/workflows/publish-marketplace-content.yaml b/.github/workflows/publish-marketplace-content.yaml index 203450125a097..b8a8cc56c6593 100644 --- a/.github/workflows/publish-marketplace-content.yaml +++ b/.github/workflows/publish-marketplace-content.yaml @@ -2,6 +2,8 @@ on: push: branches: - master + paths: + - 'components/**' jobs: publish-components: diff --git a/.github/workflows/publish-packages.yaml b/.github/workflows/publish-packages.yaml index 4be3d8deee6fe..24e36c3f98543 100644 --- a/.github/workflows/publish-packages.yaml +++ b/.github/workflows/publish-packages.yaml @@ -2,19 +2,42 @@ on: push: branches: - master + paths-ignore: + - 'docs/**' + - 'docs-v2/**' + pull_request: + branches: + - master + paths-ignore: + - 'docs/**' + - 'docs-v2/**' jobs: # See https://pnpm.io/continuous-integration#github-actions publish: + name: pnpm publish runs-on: ubuntu-latest steps: - uses: actions/checkout@v4.1.1 - uses: pnpm/action-setup@v3.0.0 with: version: 7.33.6 + - name: Get pnpm store directory + if: github.ref != 'refs/heads/master' # Cache is used only for dry runs + id: pnpm-cache + run: | + echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" + - uses: actions/cache@v4 + if: github.ref != 'refs/heads/master' # Cache is used only for dry runs + name: Setup pnpm cache + with: + path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} + key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} + restore-keys: | + ${{ runner.os }}-pnpm-store- - uses: actions/setup-node@v4.0.2 with: - node-version: 14 + node-version: 18 registry-url: https://registry.npmjs.org/ cache: 'pnpm' - name: pnpm install @@ -24,5 +47,9 @@ jobs: # See https://pnpm.io/using-changesets - name: Setup npmrc for pnpm publish run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > .npmrc + - name: pnpm publish (dry run) + if: github.ref != 'refs/heads/master' + run: pnpm publish -r --no-git-checks --dry-run - name: pnpm publish + if: github.ref == 'refs/heads/master' run: pnpm publish -r --no-git-checks diff --git a/.github/workflows/pull-request-checks.yaml b/.github/workflows/pull-request-checks.yaml index 2f38063c61cb9..aedb47d85fa9c 100644 --- a/.github/workflows/pull-request-checks.yaml +++ b/.github/workflows/pull-request-checks.yaml @@ -11,50 +11,6 @@ on: - master jobs: - check_version: - name: Ensure component commits modify component versions - runs-on: ubuntu-latest - - permissions: - contents: write - pull-requests: write - - steps: - - uses: actions/checkout@v4.1.1 - name: Checkout repo - with: - token: ${{ secrets.GITHUB_TOKEN }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - ref: ${{ github.event.pull_request.head.ref }} - # See https://github.com/actions/checkout#checkout-v2 - # This will be slow. The intent is to fetch all commits - # since the merge-base (the commit where we branched off) - # so we can check the git diff against all changed files. - # By default, the checkout action only returns the last commit, - # There's no native way to do this in the checkout action, so - # we have to fetch the entire history. See - # https://github.com/actions/checkout/issues/266#issuecomment-638346893 - fetch-depth: 0 - - uses: jitterbit/get-changed-files@v1 - id: changed_files - name: Get changed files - with: - format: json - - name: Check git diff for version changes - uses: ./.github/actions/git-diff-on-components - with: - all_files: ${{ steps.changed_files.outputs.all }} - base_commit: ${{ github.event.pull_request.base.sha }} - head_commit: ${{ github.event.pull_request.head.sha }} - - uses: stefanzweifel/git-auto-commit-action@v5 - with: - commit_message: Automatically updating actions and sources versions - commit_options: '--no-verify' - # commit_user_name: Pipedream [Bot] - # commit_user_email: pipedream@pipedream.com - # commit_author: Pipedream [Bot] - push_options: '--force' - spellcheck: name: Spellcheck runs-on: ubuntu-latest @@ -142,193 +98,3 @@ jobs: run: node scripts/checkComponentAppProp.js ${{ steps.changed_files.outputs.added_modified }} ${{ steps.changed_files.outputs.renamed }} - name: Check for duplicate component keys run: node scripts/findDuplicateKeys.js - - pnpm-publish-dry-run: - name: pnpm publish dry run - runs-on: ubuntu-latest - - steps: - - uses: actions/checkout@v4.1.1 - - uses: pnpm/action-setup@v3.0.0 - with: - version: 7.33.6 - - name: Get pnpm store directory - id: pnpm-cache - run: | - echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" - - uses: actions/cache@v4 - name: Setup pnpm cache - with: - path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} - key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} - restore-keys: | - ${{ runner.os }}-pnpm-store- - - uses: actions/setup-node@v4.0.2 - with: - node-version: 18 - registry-url: https://registry.npmjs.org/ - cache: 'pnpm' - - name: pnpm install - run: pnpm install -r - # See https://pnpm.io/using-changesets - - name: Setup npmrc for pnpm publish - run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > .npmrc - - name: pnpm publish - run: pnpm publish -r --no-git-checks --dry-run - - verify-typescript-components: - name: Verify TypeScript components - runs-on: ubuntu-latest - - steps: - - name: Checkout code - uses: actions/checkout@v4.1.1 - - uses: pnpm/action-setup@v3.0.0 - with: - version: 7.33.6 - - name: Get pnpm store directory - id: pnpm-cache - run: | - echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" - - uses: actions/cache@v4 - name: Setup pnpm cache - with: - path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} - key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} - restore-keys: | - ${{ runner.os }}-pnpm-store- - - name: Setup Node Env - uses: actions/setup-node@v4.0.2 - with: - node-version: 18 - registry-url: https://registry.npmjs.org/ - cache: 'pnpm' - - name: Install Dependencies - run: pnpm install -r - - name: Compile TypeScript - id: compile - run: npm run build > files.txt - - name: Get Changed Files - id: files - uses: jitterbit/get-changed-files@v1 - with: - format: 'csv' - - name: Check For Compiled TypeScript Files - run: | - IFS=$'\n' - # Remove initial tsc output - output_files=$(cat files.txt | sed 1,3d) - declare -a ERRORS - declare -a SKIPPED - mapfile -d ',' -t added_modified_renamed_files < <(printf '%s,%s' '${{ steps.files.outputs.added_modified }}' '${{ steps.files.outputs.renamed }}') - for added_modified_file in "${added_modified_renamed_files[@]}"; - do - echo "Checking if $added_modified_file is a publishable ts file" - if [[ $added_modified_file == components/* ]] && [[ $added_modified_file == *.ts ]] && [[ $added_modified_file != *.app.ts ]] \ - && [[ $added_modified_file != */common*.ts ]] && [[ $added_modified_file != */common/* ]] - then - # XXX This is a hacky way to publish only TS components with changes. If a changed - # file "path-a/path-b/c.ts" has a corresponding compiled output file - # "path-a/dist/path-b/c.mjs", attempt to publish the output `.mjs` file. - changed_output_file="" - for f in $output_files; # check each output file for a match - do - # Replaces /dist/path/filename.mjs with /path/filename.ts - maybe_source_file=$(echo "$f" | sed 's/\/dist\//\//;s/.mjs/\.ts/') - if [[ ${maybe_source_file} == **/${added_modified_file} ]] - then - changed_output_file=${f} - break - fi - done - if [[ $changed_output_file == "" ]] - then - ERROR_MESSAGE="cannot find an output .mjs file with ${added_modified_file}" - echo $ERROR_MESSAGE - ERRORS+=("*${ERROR_MESSAGE}") - fi - else - echo "$added_modified_file will not be added to the registry" - SKIPPED+=("*$added_modified_file") - fi - done - if [[ ${#SKIPPED[@]} -ne 0 ]]; then - echo "the following files were skipped:" - printf '%s\n' "${SKIPPED[@]}" - fi - if [[ ${#ERRORS[@]} -ne 0 ]]; then - echo "the following files generated errors:" - printf '%s\n' "${ERRORS[@]}" - echo "Please check if the components above were successfully compiled" - echo "More information here: https://pipedream.com/docs/components/typescript/#developing-typescript-components-in-the-pipedreamhq-pipedream-registry" - exit 1 - fi - unset IFS - - publish-typescript-components-dry-run: - name: Publish TypeScript components - runs-on: ubuntu-latest - - steps: - - name: Checkout code - uses: actions/checkout@v4.1.1 - - uses: pnpm/action-setup@v3.0.0 - with: - version: 7.33.6 - - name: Get pnpm store directory - id: pnpm-cache - run: | - echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" - - uses: actions/cache@v4 - name: Setup pnpm cache - with: - path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} - key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} - restore-keys: | - ${{ runner.os }}-pnpm-store- - - name: Setup Node Env - uses: actions/setup-node@v4.0.2 - with: - node-version: 18 - registry-url: https://registry.npmjs.org/ - cache: 'pnpm' - - name: Install Dependencies - run: pnpm install -r - - name: Compile TypeScript - id: compile - run: npm run build > files.txt - - name: Get Changed Files - id: files - uses: jitterbit/get-changed-files@v1 - with: - format: 'csv' - - name: Publish TypeScript components (dry run) - shell: bash {0} # don't fast fail - run: | - IFS=$'\n' - mapfile -d ',' -t added_modified_renamed_files < <(printf '%s,%s' '${{ steps.files.outputs.added_modified }}' '${{ steps.files.outputs.renamed }}') - # Remove initial tsc output - output_files=$(cat files.txt | sed 1,3d) - echo "The following files will be published on merge:" - for added_modified_file in "${added_modified_renamed_files[@]}"; - do - # starts with components, ends with .ts and not app.ts, doesn't end with /common*.ts, - # and doesn't follow */common/ - if [[ $added_modified_file == components/* ]] && [[ $added_modified_file == *.ts ]] && [[ $added_modified_file != *.app.ts ]] \ - && [[ $added_modified_file != */common*.ts ]] && [[ $added_modified_file != */common/* ]] - then - # XXX This is a hacky way to publish only TS components with changes. If a changed - # file "path-a/path-b/c.ts" has a corresponding compiled output file - # "path-a/dist/path-b/c.mjs", attempt to publish the output `.mjs` file. - for f in $output_files; - do - # Replaces /dist/path/filename.mjs with /path/filename.ts - maybe_source_file=$(echo "$f" | sed 's/\/dist\//\//;s/.mjs/\.ts/') - if [[ ${maybe_source_file} == **/${added_modified_file} ]] - then - echo "$f" - fi - done - fi - done - unset IFS From 54222d2fb5ed6ef302e89b1925d447d59b5a0a4e Mon Sep 17 00:00:00 2001 From: js07 <19861096+js07@users.noreply.github.com> Date: Mon, 4 Mar 2024 18:01:21 -0500 Subject: [PATCH 2/5] comment: todo move component checks to components workflow --- .github/workflows/pull-request-checks.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pull-request-checks.yaml b/.github/workflows/pull-request-checks.yaml index aedb47d85fa9c..9c6fef73af168 100644 --- a/.github/workflows/pull-request-checks.yaml +++ b/.github/workflows/pull-request-checks.yaml @@ -92,6 +92,7 @@ jobs: uses: jitterbit/get-changed-files@v1 with: format: 'csv' + # TODO: Move these checks to the Components workflow - name: Check component keys run: node scripts/findBadKeys.js ${{ steps.changed_files.outputs.added_modified }} ${{ steps.changed_files.outputs.renamed }} - name: Check component app prop From 0e94b0049994affc32368ab83a617ed988f3f456 Mon Sep 17 00:00:00 2001 From: js07 <19861096+js07@users.noreply.github.com> Date: Wed, 6 Mar 2024 13:20:02 -0500 Subject: [PATCH 3/5] fix: run Pull Request Checks on PR to master --- .github/workflows/pull-request-checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request-checks.yaml b/.github/workflows/pull-request-checks.yaml index b6ca21a6210a6..9c6fef73af168 100644 --- a/.github/workflows/pull-request-checks.yaml +++ b/.github/workflows/pull-request-checks.yaml @@ -8,7 +8,7 @@ name: Pull Request Checks on: pull_request: branches: - - autorev-command + - master jobs: spellcheck: From f9a368eca95b97c4bcf0b2b1304194fee00b86e5 Mon Sep 17 00:00:00 2001 From: js07 <19861096+js07@users.noreply.github.com> Date: Wed, 6 Mar 2024 13:34:32 -0500 Subject: [PATCH 4/5] move component checks to components-pr workflow --- .github/workflows/components-pr.yaml | 47 ++++++++++++++++++++++ .github/workflows/pull-request-checks.yaml | 14 ------- 2 files changed, 47 insertions(+), 14 deletions(-) diff --git a/.github/workflows/components-pr.yaml b/.github/workflows/components-pr.yaml index 08bebce1e3521..5bf9bf9bc2810 100644 --- a/.github/workflows/components-pr.yaml +++ b/.github/workflows/components-pr.yaml @@ -42,6 +42,53 @@ jobs: base_commit: ${{ github.event.pull_request.base.sha }} head_commit: ${{ github.event.pull_request.head.sha }} + check_components: + name: Check component keys and app props + runs-on: ubuntu-latest + + steps: + - name: Checkout Code + uses: actions/checkout@v4.1.1 + with: + # Full git history is needed to get a proper list of changed files + # within `super-linter` + fetch-depth: 0 + - uses: pnpm/action-setup@v3.0.0 + with: + version: 7.33.6 + - name: Get pnpm store directory + id: pnpm-cache + run: | + echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" + - uses: actions/cache@v4 + name: Setup pnpm cache + with: + path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} + key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} + restore-keys: | + ${{ runner.os }}-pnpm-store- + - name: Install dependencies + run: pnpm install -r + - name: Setup Node Env + uses: actions/setup-node@v4.0.2 + with: + node-version: 18 + registry-url: https://registry.npmjs.org/ + cache: 'pnpm' + - name: Compile TypeScript + run: npm run build + - name: Get Changed Files + id: changed_files + uses: jitterbit/get-changed-files@v1 + with: + format: 'csv' + - name: Check component keys + run: node scripts/findBadKeys.js ${{ steps.changed_files.outputs.added_modified }} ${{ steps.changed_files.outputs.renamed }} + - name: Check component app prop + run: node scripts/checkComponentAppProp.js ${{ steps.changed_files.outputs.added_modified }} ${{ steps.changed_files.outputs.renamed }} + - name: Check for duplicate component keys + run: node scripts/findDuplicateKeys.js + verify-typescript-components: name: Verify TypeScript components runs-on: ubuntu-latest diff --git a/.github/workflows/pull-request-checks.yaml b/.github/workflows/pull-request-checks.yaml index 9c6fef73af168..8daad56185387 100644 --- a/.github/workflows/pull-request-checks.yaml +++ b/.github/workflows/pull-request-checks.yaml @@ -75,8 +75,6 @@ jobs: node-version: 18 registry-url: https://registry.npmjs.org/ cache: 'pnpm' - - name: Compile TypeScript - run: npm run build - name: Lint Code Base uses: github/super-linter@v5 env: @@ -87,15 +85,3 @@ jobs: VALIDATE_ALL_CODEBASE: false VALIDATE_JAVASCRIPT_ES: true VALIDATE_JSON: true - - name: Get Changed Files - id: changed_files - uses: jitterbit/get-changed-files@v1 - with: - format: 'csv' - # TODO: Move these checks to the Components workflow - - name: Check component keys - run: node scripts/findBadKeys.js ${{ steps.changed_files.outputs.added_modified }} ${{ steps.changed_files.outputs.renamed }} - - name: Check component app prop - run: node scripts/checkComponentAppProp.js ${{ steps.changed_files.outputs.added_modified }} ${{ steps.changed_files.outputs.renamed }} - - name: Check for duplicate component keys - run: node scripts/findDuplicateKeys.js From 58892a5d8c98234ceed7674ea99197a350203b47 Mon Sep 17 00:00:00 2001 From: js07 <19861096+js07@users.noreply.github.com> Date: Wed, 6 Mar 2024 13:36:54 -0500 Subject: [PATCH 5/5] test components change --- .../google_sheets/actions/list-worksheets/list-worksheets.mjs | 2 +- components/google_sheets/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/components/google_sheets/actions/list-worksheets/list-worksheets.mjs b/components/google_sheets/actions/list-worksheets/list-worksheets.mjs index c894a73dbada4..a5baa79f74510 100644 --- a/components/google_sheets/actions/list-worksheets/list-worksheets.mjs +++ b/components/google_sheets/actions/list-worksheets/list-worksheets.mjs @@ -4,7 +4,7 @@ export default { key: "google_sheets-list-worksheets", name: "List Worksheets", description: "Get a list of all worksheets in a spreadsheet", - version: "0.1.2", + version: "0.1.3", type: "action", props: { googleSheets, diff --git a/components/google_sheets/package.json b/components/google_sheets/package.json index a3ad240c4e5f8..110866d606f74 100644 --- a/components/google_sheets/package.json +++ b/components/google_sheets/package.json @@ -1,6 +1,6 @@ { "name": "@pipedream/google_sheets", - "version": "0.6.2", + "version": "0.6.3", "description": "Pipedream Google_sheets Components", "main": "google_sheets.app.mjs", "keywords": [