Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script makes assumptions about platform and jar module names #1

Open
jpotts opened this issue Feb 1, 2019 · 1 comment
Open

Script makes assumptions about platform and jar module names #1

jpotts opened this issue Feb 1, 2019 · 1 comment

Comments

@jpotts
Copy link
Owner

jpotts commented Feb 1, 2019

Currently the script assumes that platform and jar modules and directories are named *-platform-jar and *-share-jar, which is fine for out-of-the-box projects, but many people rename these modules.

Instead of relying on a specific name pattern, we could inspect the pom.xml files and determine which is which, regardless of how they are named.

@omar-ounoughi
Copy link
Collaborator

We handle this also in jar that merge the main pom.xml, it's easier to extract this information with java libraries and it can be reused by widows script.

We also need to keep changes that are made in pom.xml of the modules.
I'll work on it Sunday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants