Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-F 'scroll down full page' conflicts with native find shortcut #24

Open
pseigo opened this issue Feb 1, 2020 · 4 comments
Open

Comments

@pseigo
Copy link

pseigo commented Feb 1, 2020

Hi,

Would it be possible to implement a setting to change the 'Scroll down full page' Ctrl-F shortcut? It conflicts with the native VSCode 'Find' shortcut. The 'Differences From Vim' section explains why the vim search command was removed,

SimpleVim has no / (search) command. Instead you can either use the f motion or the native VSCode find. Between them most of the uses for / are taken care of.

but does not explain why the native shortcut was overwritten. This likely goes against the project's philosophy, in that

SimpleVim prioritizes simplicity and integration with native VSCode features over compatibility with Vim.

We still have the project-wide search (Ctrl-Shift-F) but this isn't practical for searching a single file. I often use Ctrl-F or / to search without using the mouse (pretty much the reason why I like vim) but that doesn't seem to be possible with the extension's current implementation.

I'd love to hear your thoughts on this and whether this was an intentional design choice or perhaps an oversight.

Thanks!

@jpotterm
Copy link
Owner

This was definitely not intentional and it's because I use a mac so the native find shortcut is Cmd+f which doesn't conflict. I agree that this default should be changed in SimpleVim but I don't have time at the moment. Luckily it's trivial for users to override so you can do that yourself in VSCode's Keyboard Shortcuts screen. Just search for extension.simpleVim.scrollDownPage and change the shortcut to whatever you like.

@pseigo
Copy link
Author

pseigo commented Feb 13, 2020

Aha, makes sense. Thanks for following up!

@necesitod
Copy link

Hello could you remove the shotcuts ctrl f and ctrl b. Clog for Linux and Windows versions. Besides you can solve it with vim Shift G to go to the end and gg to go to the beginning. And you leave the universal mapping unchanged. Thanks in advance. And by the way your extension is luxurious, for those of us who love vim it helps a lot. The best of both worlds

@jpotterm
Copy link
Owner

@necesitod You can remove that shortcut yourself via VSCode's keyboard shortcut settings (see my comment above). I agree that on Linux and Windows it should be changed by default, but I don't have time to do that at the moment because I'm crazy busy. Thanks for the feedback and I'm so glad you're liking the extension! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants