Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mget is using result.length before checking for an error #22

Open
gechols opened this issue Jul 1, 2020 · 1 comment
Open

mget is using result.length before checking for an error #22

gechols opened this issue Jul 1, 2020 · 1 comment

Comments

@gechols
Copy link
Contributor

gechols commented Jul 1, 2020

We have a case where we are running out of connections and the line: https://github.com/jpodwys/cache-service-redis/blob/master/redisCacheModule.js#L176 throws an exception that hides the actual error. This throws an exception when result.length is used before checking to see if err is set or response is not set. You have code elsewhere that checks for if (!err && response) This would help solve this problem.

@jpodwys
Copy link
Owner

jpodwys commented Jul 1, 2020

Thank you for reporting this issue! I'd be happy to accept a pull request to address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants