Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date Picker example shows controlled/uncontrolled switch warning #4069

Closed
origami-z opened this issue Sep 10, 2024 · 3 comments
Closed

Date Picker example shows controlled/uncontrolled switch warning #4069

origami-z opened this issue Sep 10, 2024 · 3 comments
Labels
community For issues that have been raised by folks outside the core Salt team component: date picker package: lab Lab package

Comments

@origami-z
Copy link
Contributor

const [selectedDate, setSelectedDate] = useState(undefined) will trigger controlled/uncontrolled switch warning for

<DatePicker
        selectedDate={selectedDate}

https://www.saltdesignsystem.com/salt/components/date-picker/examples#with-validation
@origami-z origami-z added package: lab Lab package community For issues that have been raised by folks outside the core Salt team component: date picker labels Sep 10, 2024
@origami-z
Copy link
Contributor Author

Hopefully should be closed by #3716, cc @mark-tate

@mark-tate
Copy link
Contributor

Yes... worked on this, folks experiencing this or requiring this, please join the 3716 review

@mark-tate
Copy link
Contributor

This has been fixed in labs and is now a release candidate, we welcome feedback so we can move datepicker to Core

Please refer to #4096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community For issues that have been raised by folks outside the core Salt team component: date picker package: lab Lab package
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mark-tate @origami-z