Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update react-jPlayer to support react-redux version 6.x and above #25

Open
singhjagmohan1000 opened this issue Feb 28, 2019 · 4 comments

Comments

@singhjagmohan1000
Copy link

No description provided.

@isautkin-nv
Copy link

Any known fix for this?

@iholovach-amplify
Copy link

iholovach-amplify commented Jan 29, 2021

@MartinDawson @Mattomanka hey, i am wondering if you are planning to update react-jPlayer & react-jPlaylist to support react 16 + and react redux 6 + versions

@MartinDawson
Copy link
Contributor

@iholovach-amplify I recommend not using this package and use another react player.

I am no longer using it or updating it. If someone else wants to take over the contributions to the package then they can.

@iholovach-amplify
Copy link

iholovach-amplify commented Feb 3, 2021

@singhjagmohan1000 @isautkin-nv hey, looks that there is one easy way to fix it, just remove react, redux, react-redux dependencies from dependencies in react-jplaylist, react-jplayer and react-jplayer-utils libs
(but live in devDependencies)

  • so in such case it will use your application libs versions without any problems

@MartinDawson hey, if this fix works for you, could you please create 3 PRS to remove those dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants