Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sf: sound effects have a chance to interrupt music playback in Street Fighter #969

Open
Thelypody opened this issue Feb 10, 2025 · 4 comments
Assignees
Labels
core bug Something isn't working

Comments

@Thelypody
Copy link

Street Fighter (US, set 1)
Running on MiSTer (Terasic DE10-Nano) via Analog IO Board.

On the current version of the jtsf core Street Fighter has an issue with audio playback. Throwing a punch or a kick has a chance of interrupting background music for a brief time, presumably caused by sound effects playing at the same time. This is observable both in normal gameplay and arcade's attract mode.

@jotego jotego added the question Further information is requested label Feb 10, 2025
@jtmiki jtmiki added core bug Something isn't working and removed question Further information is requested labels Feb 10, 2025
@jtmiki
Copy link
Collaborator

jtmiki commented Feb 10, 2025

I have tested it on today's compile all on MiSTer, commit: b656448.
As Thelypody said during a punch or a kick attack, the background music is interrupted.
This did not occur in MAME.
The referee's ROUND calls are also muffled and difficult to hear.

@jotego
Copy link
Owner

jotego commented Feb 10, 2025

This occurs because the PCM sound is too loud and clips the whole sound. @jtmiki please try to identify the commit that broke the core

@jtmiki
Copy link
Collaborator

jtmiki commented Feb 11, 2025

I have found two commits of the same date that the core didn't work well.
I attach screen shots of these two commits. The date was on the 12/1/2025.
Commit: 94cbdd7

Image

Commit: f3ba22e

Image

@jtmiki
Copy link
Collaborator

jtmiki commented Feb 13, 2025

I have found the commit that broke the core.
Since the commit 31/12/24, 0b0559b, the background music has been interrupted during attacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants