You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pr mentions this requires big changes: #99. But this seems like a feature that is important to implement for performance. How doable is it in the current state of the library? I would like to work on it if possible
The text was updated successfully, but these errors were encountered:
Hey! @jorgecarleitao can you give guidence on this? I started doing it. What I come up with is something like this:
/// Creates a bloom filter from the bitset and writes it into the `writer`.pubfnwrite<R:Write + Seek>(column_metadata:&mutColumnChunkMetaData,mutwriter:&mutW,bitset:&[u8],) -> Result<(),Error>{// create bloom filter header// create TCompactInputProtocol containing the bloom filter// write the offset to column_metadata// write the bloom filter to the writer}
does it look correct?
edit: actually I found that is should be something like this:
/// Creates a bloom filter from the bitset and writes it into the `writer`.pubfnwrite(protocol:&mutTCompactOutputProtocol,bitset:&[u8],) -> Result<(),Error>{// create bloom filter header// create TCompactInputProtocol containing the bloom filter// write the offset to column_metadata// write the bloom filter to the protocol}
This pr mentions this requires big changes: #99. But this seems like a feature that is important to implement for performance. How doable is it in the current state of the library? I would like to work on it if possible
The text was updated successfully, but these errors were encountered: