Some docblocks improvements

and a few strings in messages.

Author: HermanPeeren

src/administrator/components/com_ccm/src/Controller/DisplayController.php

@@ -29,11 +29,12 @@ class DisplayController extends BaseController
     /**
      * Method to display a view.
      *
-     * @param   boolean  $cachable   If true, the view output will be cached
-     * @param   array    $urlparams  An array of safe URL parameters and their variable types, for valid values see {@link \JFilterInput::clean()}.
+     * @param boolean $cachable If true, the view output will be cached
+     * @param array $urlparams An array of safe URL parameters and their variable types, for valid values see {@link \JFilterInput::clean()}.
      *
      * @return  static  This object to support chaining.
      *
+     * @throws \Exception
      * @since 1.0.0
      */
     public function display($cachable = false, $urlparams = [])

src/administrator/components/com_ccm/src/Controller/MigrationController.php

@@ -18,6 +18,13 @@
 
 class MigrationController extends BaseController
 {
+    /**
+     * Apply migration from source CMS to target CMS.
+     *
+     * @return void
+     *
+     * @since 1.0.0
+     */
     public function apply()
     {
         $data = $this->input->post->get('jform', [], 'array');
@@ -30,7 +37,7 @@ public function apply()
         $sourceCmsId = isset($data['source_cms']) ? (int) $data['source_cms'] : 0;
         $targetCmsId = isset($data['target_cms']) ? (int) $data['target_cms'] : 0;
 
-        /** @var MigrationModel $model */
+        /** @var \Joomla\Component\CCM\Administrator\Model\MigrationModel $model */
         $model = $this->getModel();
 
         try {
@@ -72,15 +79,15 @@ public function apply()
                 $this->setMessage(Text::_('COM_CCM_MESSAGE_MIGRATION_COMPLETED_SUCCESSFULLY') . implode(', ', $successfulMigrations));
             } elseif (!empty($successfulMigrations) && !empty($failedMigrations)) {
                 $message = Text::_('COM_CCM_MESSAGE_MIGRATION_COMPLETED_PARTIALLY');
-                $message .= Text::_('Successful: ') . implode(', ', $successfulMigrations) . '. ';
-                $message .= Text::_('Failed: ') . implode(', ', $failedMigrations);
+                $message .= Text::_('COM_CCM_MESSAGE_MIGRATION_SUCCESSFUL') . implode(', ', $successfulMigrations) . '. ';
+                $message .= Text::_('COM_CCM_MESSAGE_MIGRATION_FAILED') . implode(', ', $failedMigrations);
                 $this->setMessage($message, 'warning');
             } else {
-                $this->setMessage(Text::_('All migrations failed: ') . implode(', ', $failedMigrations), 'error');
+                $this->setMessage(Text::_('COM_CCM_MESSAGE_MIGRATION_FAILED_ALL') . implode(', ', $failedMigrations), 'error');
             }
 
         } catch (\Exception $e) {
-            $this->setMessage(Text::_('Migration failed: ') . $e->getMessage(), 'error');
+            $this->setMessage(Text::_('COM_CCM_MESSAGE_MIGRATION_FAILED_THIS') . $e->getMessage(), 'error');
         }
         $this->setRedirect('index.php?option=com_ccm&view=migration');
     }

src/administrator/components/com_ccm/src/Model/MigrationModel.php

@@ -84,9 +84,9 @@ protected function loadFormData()
     /**
      * Migrate from source CMS to target CMS.
      *
-     * @return  void
+     * @return  boolean
      *
-     * @since   4.0.0
+     * @since   1.0.0
      */
     public function migrate($sourceCmsId, $targetCmsId, $sourceType, $targetType)
     {

src/administrator/components/com_ccm/src/View/Migration/HtmlView.php

@@ -16,7 +16,7 @@
 use Joomla\CMS\Language\Text;
 use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
 use Joomla\CMS\Toolbar\ToolbarHelper;
-use Joomla\Component\CCM\Administrator\Migration\Migration;
+use Joomla\Component\CCM\Administrator\Model\MigrationModel;
 
 class HtmlView extends BaseHtmlView
 {
@@ -26,7 +26,7 @@ class HtmlView extends BaseHtmlView
 
     public function display($tpl = null): void
     {
-        /** @var Migration $model */
+        /** @var MigrationModel $model */
         $model = $this->getModel();
 
         $this->item  = $model->getItem();