Skip to content

shell path invalid #45

@rickysarraf

Description

@rickysarraf
rrs@priyasi:~/.local/share/gnome-shell$ grep -Ri "/usr/bin/sh" *
extensions/laine@knasher.gmail.com/portMenu.js:const UPDATE_FALLBACK_SINK_CMD = "/usr/bin/sh -c  \"/usr/bin/pacmd set-default-sink $(/usr/bin/pacmd list-sinks | awk '/* index:/ {print $3}')\"";
extensions/laine@knasher.gmail.com/portMenu.js:const UPDATE_FALLBACK_SOURCE_CMD = "/usr/bin/sh -c  \"/usr/bin/pacmd set-default-source $(/usr/bin/pacmd list-sources | awk '/* index:/ {print $3}')\"";
15:39 ♒♒♒   ☺ 😄    

The hardcoded path, /usr/bin/sh, is invalid on systems where usrmerge has not been adopted by the Linux Distribution vendor. An example of it is Debian, which has the usrmerge feature left out as an additional task for users and is not enabled by default.

It would be better to hardcode /bin/sh instead because usrmerge is also guaranteed to create symllinks to old paths, for compatibility. That way both users can be covered.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions