From 9c2a024f8771f1062630bf6382ed1a8f4172a9b9 Mon Sep 17 00:00:00 2001 From: CSadek Date: Tue, 9 Jan 2018 19:23:11 +0200 Subject: [PATCH 1/3] use standalone --- runtime/chromeDriver.js | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/runtime/chromeDriver.js b/runtime/chromeDriver.js index 4d06b62..649b7ca 100644 --- a/runtime/chromeDriver.js +++ b/runtime/chromeDriver.js @@ -1,23 +1,16 @@ 'use strict'; -var chromedriver = require('chromedriver'); var selenium = require('selenium-webdriver'); /** * Creates a Selenium WebDriver using Chrome as the browser * @returns {ThenableWebDriver} selenium web driver */ -module.exports = function() { +module.exports = function () { - var driver = new selenium.Builder().withCapabilities({ - browserName: 'chrome', - javascriptEnabled: true, - acceptSslCerts: true, - chromeOptions: { - args: ['start-maximized'] - }, - path: chromedriver.path - }).build(); + var driver = new selenium.Builder(). + usingServer('http://localhost:4444/wd/hub'). + withCapabilities(selenium.Capabilities.chrome()).build(); driver.manage().window().maximize(); From 294f142454b96d7148558a12ce8da8662f821b03 Mon Sep 17 00:00:00 2001 From: CSadek Date: Sun, 18 Mar 2018 15:14:59 +0200 Subject: [PATCH 2/3] revert --- runtime/chromeDriver.js | 16 +++++++++++----- runtime/world.js | 3 ++- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/runtime/chromeDriver.js b/runtime/chromeDriver.js index 649b7ca..79951a1 100644 --- a/runtime/chromeDriver.js +++ b/runtime/chromeDriver.js @@ -1,16 +1,22 @@ 'use strict'; - +var chromedriver = require('chromedriver'); var selenium = require('selenium-webdriver'); /** * Creates a Selenium WebDriver using Chrome as the browser * @returns {ThenableWebDriver} selenium web driver */ -module.exports = function () { +module.exports = function() { - var driver = new selenium.Builder(). - usingServer('http://localhost:4444/wd/hub'). - withCapabilities(selenium.Capabilities.chrome()).build(); + var driver = new selenium.Builder().withCapabilities({ + browserName: 'chrome', + javascriptEnabled: true, + acceptSslCerts: true, + chromeOptions: { + args: ['start-maximized'] + }, + path: chromedriver.path + }).build(); driver.manage().window().maximize(); diff --git a/runtime/world.js b/runtime/world.js index 5034378..96fd330 100755 --- a/runtime/world.js +++ b/runtime/world.js @@ -63,7 +63,8 @@ function getDriverInstance() { throw new Error('Could not find driver file: ' + driverFileName); } - driver = require(driverFileName)(); + var CustomDriver = require(driverFileName)(); + driver = new CustomDriver(); } } From e794ba4a0cc74635ab24ce447dc7afd9507fc7c9 Mon Sep 17 00:00:00 2001 From: CSadek Date: Sun, 18 Mar 2018 15:16:27 +0200 Subject: [PATCH 3/3] revert --- runtime/chromeDriver.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/runtime/chromeDriver.js b/runtime/chromeDriver.js index 79951a1..4d06b62 100644 --- a/runtime/chromeDriver.js +++ b/runtime/chromeDriver.js @@ -1,4 +1,5 @@ 'use strict'; + var chromedriver = require('chromedriver'); var selenium = require('selenium-webdriver'); @@ -16,7 +17,7 @@ module.exports = function() { args: ['start-maximized'] }, path: chromedriver.path - }).build(); + }).build(); driver.manage().window().maximize();