fix(Ads): Fix bad static overlay ad position (shaka-project#7735)

avelad · web-flow · commit e4825c303bdf · 2024-12-10T17:04:09.000+01:00
diff --git a/lib/ads/interstitial_ad_manager.js b/lib/ads/interstitial_ad_manager.js
@@ -794,7 +794,6 @@ shaka.ads.InterstitialAdManager = class {
       htmlElement.style.left = (topLeft.x / viewport.x * 100) + '%';
       htmlElement.style.top = (topLeft.y / viewport.y * 100) + '%';
       htmlElement.style.width = (size.x / viewport.x * 100) + '%';
-      htmlElement.style.height = 'auto';
     }
     this.adContainer_.appendChild(htmlElement);
 

Original file line number	Diff line number	Diff line change
`@@ -794,7 +794,6 @@ shaka.ads.InterstitialAdManager = class {`
`794`	`794`	`htmlElement.style.left = (topLeft.x / viewport.x * 100) + '%';`
`795`	`795`	`htmlElement.style.top = (topLeft.y / viewport.y * 100) + '%';`
`796`	`796`	`htmlElement.style.width = (size.x / viewport.x * 100) + '%';`
`797`		`- htmlElement.style.height = 'auto';`
`798`	`797`	`}`
`799`	`798`	`this.adContainer_.appendChild(htmlElement);`
`800`	`799`