Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable noUncheckedIndexedAccess typescript option #711

Open
jkomoros opened this issue Feb 17, 2025 · 1 comment
Open

Enable noUncheckedIndexedAccess typescript option #711

jkomoros opened this issue Feb 17, 2025 · 1 comment

Comments

@jkomoros
Copy link
Owner

Without it, object index accesses are assumed to always succed, which means there are cases where a value could be undefined that Typescript wouldn't report.

noUncheckedIndexedAccess

jkomoros added a commit that referenced this issue Feb 17, 2025
jkomoros added a commit that referenced this issue Feb 17, 2025
jkomoros added a commit that referenced this issue Feb 17, 2025
jkomoros added a commit that referenced this issue Feb 17, 2025
jkomoros added a commit that referenced this issue Feb 17, 2025
jkomoros added a commit that referenced this issue Feb 17, 2025
jkomoros added a commit that referenced this issue Feb 17, 2025
jkomoros added a commit that referenced this issue Feb 17, 2025
jkomoros added a commit that referenced this issue Feb 17, 2025
jkomoros added a commit that referenced this issue Feb 17, 2025
@jkomoros
Copy link
Owner Author

Wow is this a pain in the butt to mechanically add!

When adding it:

Modify tsconfig.json to add noUncheckedIndexedAccess and also nocommit, and then make changes, then if you want to make sure you didn't bfreak anything, stash tsconfig and check it's ok to land then unstash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant