From 1262a5dac73dd7ea2d995df99f987605ba428aff Mon Sep 17 00:00:00 2001
From: Alex Komoroske <jkomoros@gmail.com>
Date: Sun, 7 Apr 2024 18:59:43 -0700
Subject: [PATCH] More logging in semanticSort, which helps see why it isn't
 swapping very often.

Part of #688.
---
 functions/src/embeddings.ts | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/functions/src/embeddings.ts b/functions/src/embeddings.ts
index 748c19ed..2d3aa417 100644
--- a/functions/src/embeddings.ts
+++ b/functions/src/embeddings.ts
@@ -546,7 +546,25 @@ const swapIfBetter = (index: number, cards : CardID[], vectors: Record<CardID, E
 	const d = vectors[dID];
 
 	//This might happen for cards that don't have embeddings yet.
-	if (!a || !b || !c || !d) return false;
+	if (!a) {
+		console.warn(`No embedding for ${aID}`);
+		return false;
+	}
+
+	if (!b) {
+		console.warn(`No embedding for ${bID}`);
+		return false;
+	}
+
+	if (!c) {
+		console.warn(`No embedding for ${cID}`);
+		return false;
+	}
+
+	if (!d) {
+		console.warn(`No embedding for ${dID}`);
+		return false;
+	}
 
 	//b anc c will be next to each other no matter what. We're seeing which is
 	//better, similarity(a,b) + similarity(c,d) (in which case there should be
@@ -558,7 +576,11 @@ const swapIfBetter = (index: number, cards : CardID[], vectors: Record<CardID, E
 	const simAC = cosineSimilarity(a, c);
 	const simBD = cosineSimilarity(b, d);
 
+	console.log(`Comparing ${bID} and ${cID} with ${simAB} + ${simCD} (${simAB + simCD}) vs ${simAC} + ${simBD} (${simAC + simBD})`);
+
 	if (simAB + simCD >= simAC + simBD) return false;
+	
+	console.log('Swapping');
 
 	//A swap is better!
 	const temp = cards[index];