Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes invoker returns OK result when there was a failure #3

Open
p4vook opened this issue Jan 26, 2021 · 1 comment
Open

Sometimes invoker returns OK result when there was a failure #3

p4vook opened this issue Jan 26, 2021 · 1 comment

Comments

@p4vook
Copy link
Member

p4vook commented Jan 26, 2021

When minion::spawn returns an error, invoker returns OK with spawn_error set to true. However, sometimes this indicates that sandbox failed before even starting a command. This should be considered as a failure.

@p4vook p4vook mentioned this issue Jan 26, 2021
@MikailBag
Copy link
Member

Launch failure can have legitimate reasons. E.g. some compilers can produce invalid binary given invalid programs.

Currently. I don't see good criteria for distinction "a launch error caused by an error in the program | a launch error caused by an error in the invoke request | a launch error caused by a bug in the invoker".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants