Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Close frame #26

Open
jgraef opened this issue Aug 19, 2024 · 0 comments
Open

Optional Close frame #26

jgraef opened this issue Aug 19, 2024 · 0 comments

Comments

@jgraef
Copy link
Owner

jgraef commented Aug 19, 2024

tungstenite sometimes gives us Message::Close(None), but we can't handle this at the moment. We expect there to always be a close code and reason, and currently just use CloseCode::default() and String::default(). We should change this to allow an empty close message. This would be a breaking change, so we'll wait for the next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant