Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Revert thin amboso change from 1.9 #114

Open
Tracked by #113
jgabaut opened this issue Aug 28, 2024 · 0 comments
Open
Tracked by #113

[FEATURE] Revert thin amboso change from 1.9 #114

jgabaut opened this issue Aug 28, 2024 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@jgabaut
Copy link
Owner

jgabaut commented Aug 28, 2024

Ever since amboso turned into a thin script sourcing amboso_fn.sh (so >=1.9), I've been wondering if it was actually a good choice.

Having the script be a single file would allow for easier portability (avoiding the need to precisely locate the symbols to source), but it may come at a cost.

For now, the idea was that a globally-installed anvil would check the amboso-dir directory to source the local symbols.

  • This would be scrapped and the project compatibility would be checked by an explicit key in the stego.lock file (currently, it would be the anvil.version key).
  • This would break the existing link between the project-provided anvil and a system one
@jgabaut jgabaut added the enhancement New feature or request label Aug 28, 2024
@jgabaut jgabaut changed the title [FEATURE] Avoid resorting to file source as a means of ensuring portability [FEATURE] Revert thin client change from 1.9 Aug 28, 2024
@jgabaut jgabaut added the question Further information is requested label Aug 28, 2024
@jgabaut jgabaut changed the title [FEATURE] Revert thin client change from 1.9 [FEATURE] Revert thin amboso change from 1.9 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Development

No branches or pull requests

1 participant