Commit 9773bc4
Fix getBytesRef in ConstantBytesRefVector (elastic#136445)
We should not return the BytesRef directly from ConstantBytesRefBlock,
but instead copy its slice to a scratch buffer. Although current usage
does not modify the offset and length, the contract should allow callers
to change these fields, as long as the content of the bytes array
remains unchanged. The usage pattern below should be fine, but currently
it can change ConstantBytesRefBlock.1 parent 144a2fc commit 9773bc4
File tree
3 files changed
+17
-4
lines changed- x-pack/plugin/esql/compute/src
- main
- generated-src/org/elasticsearch/compute/data
- java/org/elasticsearch/compute/data
- test/java/org/elasticsearch/compute/data
3 files changed
+17
-4
lines changedLines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
44 | 48 | | |
45 | 49 | | |
46 | | - | |
47 | 50 | | |
| 51 | + | |
48 | 52 | | |
49 | 53 | | |
50 | 54 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
818 | 818 | | |
819 | 819 | | |
820 | 820 | | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
821 | 827 | | |
822 | 828 | | |
823 | 829 | | |
| |||
0 commit comments