Skip to content

fix: mDNS scan to no longer block event loop#43

Open
doron1 wants to merge 3 commits into
jfmlima:mainfrom
doron1:patch1-mdns
Open

fix: mDNS scan to no longer block event loop#43
doron1 wants to merge 3 commits into
jfmlima:mainfrom
doron1:patch1-mdns

Conversation

@doron1
Copy link
Copy Markdown

@doron1 doron1 commented May 19, 2026

mDNS scan on a relatively large Shelly shop would hang almost every time, requiring a docker restart due to zombie scanners that were blocking. Fix the zeroconf scanner to never block.

Copy link
Copy Markdown
Owner

@jfmlima jfmlima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @doron1, thanks a lot for this, left some comments 👍

Comment thread packages/core/src/core/gateways/network/zeroconf_mdns_client.py Outdated
Comment thread packages/core/src/core/gateways/network/zeroconf_mdns_client.py
Copy link
Copy Markdown
Owner

@jfmlima jfmlima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing

Comment thread packages/core/src/core/gateways/network/zeroconf_mdns_client.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants