Skip to content

Commit 4409115

Browse files
authored
[lock-tidy] Put warning behind feature flag (#2171)
## Summary `--tidy-lockfile` is not reliable, so put this warning behind a feature flag until it is fixed. ## How was it tested? Ran `devbox install` with missing outputs in lockfile, did not see error.
1 parent ac28b01 commit 4409115

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
// Copyright 2024 Jetify Inc. and contributors. All rights reserved.
2+
// Use of this source code is governed by the license in the LICENSE file.
3+
4+
package featureflag
5+
6+
var TidyWarning = disable("TIDY_WARNING")

internal/devpkg/package.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import (
1414

1515
"github.com/pkg/errors"
1616
"github.com/samber/lo"
17+
"go.jetpack.io/devbox/internal/boxcli/featureflag"
1718
"go.jetpack.io/devbox/internal/boxcli/usererr"
1819
"go.jetpack.io/devbox/internal/cachehash"
1920
"go.jetpack.io/devbox/internal/debug"
@@ -746,7 +747,7 @@ func (p *Package) GetStorePaths(ctx context.Context, w io.Writer) ([]string, err
746747
return storePathsForPackage, err
747748
}
748749

749-
if p.IsDevboxPackage {
750+
if featureflag.TidyWarning.Enabled() && p.IsDevboxPackage {
750751
// No fast path, we need to query nix.
751752
ux.FHidableWarning(ctx, w, MissingStorePathsWarning, p.Raw)
752753
}

0 commit comments

Comments
 (0)