upgrade dependency to the latest (#97)

Author: connectdotz

.eslintrc.js

@@ -11,20 +11,20 @@ module.exports = {
   },
   settings: {
     'import/parsers': {
-      'babel-eslint': ['.js'],
+      '@babel/eslint-parser': ['.js'],
       '@typescript-eslint/parser': ['.ts'],
     },
     'import/resolver': {
       node: true,
       'eslint-import-resolver-typescript': true,
     },
   },
-  parser: 'babel-eslint',
+  parser: '@babel/eslint-parser',
   parserOptions: {
     sourceType: 'module',
     babelOptions: {
-      // configuration for babel-eslint
-      configFile: 'babel.config.js',
+      // configuration for @babel/eslint-parser
+      configFile: './babel.config.js',
     },
     // configuration for @typescript-eslint
     project: 'tsconfig.json',
@@ -33,10 +33,11 @@ module.exports = {
     // linting setup for JS files.
     {
       files: '**/*.js',
-      plugins: ['babel', 'flowtype', 'prettier', 'import'],
+      parser: '@babel/eslint-parser',
+      plugins: ['@babel', 'flowtype', 'prettier', 'import'],
       extends: ['airbnb-base', 'plugin:flowtype/recommended', 'prettier', 'plugin:prettier/recommended'],
       rules: {
-        'prettier/prettier': ["error", { "endOfLine": "auto" }],
+        'prettier/prettier': ['error', {endOfLine: 'auto'}],
         'no-underscore-dangle': 'off',
         camelcase: 'off',
         'no-param-reassign': ['error', {props: false}],
@@ -53,7 +54,7 @@ module.exports = {
     // linting setup for TS files.
     {
       files: '**/*.ts',
-      plugins: ['babel', 'prettier', 'import', '@typescript-eslint'],
+      plugins: ['@babel', 'prettier', 'import', '@typescript-eslint'],
       extends: [
         'airbnb-typescript/base',
         'plugin:@typescript-eslint/eslint-recommended',
@@ -63,7 +64,7 @@ module.exports = {
         'plugin:prettier/recommended',
       ],
       rules: {
-        'prettier/prettier': ["error", { "endOfLine": "auto" }],
+        'prettier/prettier': ['error', {endOfLine: 'auto'}],
         'no-underscore-dangle': 'off',
         camelcase: 'off',
         'no-param-reassign': ['error', {props: false}],

.flowconfig

@@ -1,4 +1,5 @@
 [ignore]
+<PROJECT_ROOT>/node_modules/resolve/.*
 
 [include]
 src
@@ -9,9 +10,9 @@ flow-typed
 
 
 [lints]
+untyped-type-import=warn
 
 [options]
-esproposal.optional_chaining=enable
 module.file_ext=.js
 module.file_ext=.ts
 

.npmignore

@@ -9,6 +9,11 @@ fixtures
 .eslintrc.js
 babel.config.js
 prettier.config.js
+tsconfig.json
 dangerfile.js
 yarn.lock
 *.tgz
+flow-typed/**
+.gitattributes
+.github/**
+.husky/**

package.json

@@ -30,38 +30,40 @@
     "prepare": "husky install"
   },
   "devDependencies": {
-    "@babel/cli": "^7.15.7",
-    "@babel/core": "^7.15.5",
-    "@babel/preset-env": "^7.15.6",
-    "@babel/preset-flow": "^7.14.5",
-    "@babel/preset-typescript": "^7.15.0",
-    "@types/jest": "^27.0.1",
-    "@typescript-eslint/eslint-plugin": "^4.31.1",
-    "@typescript-eslint/parser": "^4.31.1",
-    "babel-eslint": "^10.1.0",
-    "babel-jest": "^27.2.0",
-    "eslint": "^7.32.0",
-    "eslint-config-airbnb-base": "^14.2.1",
-    "eslint-config-airbnb-typescript": "^14.0.0",
-    "eslint-config-prettier": "^8.3.0",
-    "eslint-import-resolver-typescript": "^2.5.0",
-    "eslint-plugin-babel": "^5.3.1",
-    "eslint-plugin-flowtype": "^6.0.1",
-    "eslint-plugin-import": "^2.24.2",
-    "eslint-plugin-prettier": "^4.0.0",
-    "flow-bin": "^0.97.0",
+    "@babel/cli": "^7.19.3",
+    "@babel/core": "^7.20.5",
+    "@babel/eslint-parser": "^7.19.1",
+    "@babel/eslint-plugin": "^7.19.1",
+    "@babel/plugin-transform-react-jsx": "^7.19.0",
+    "@babel/preset-env": "^7.20.2",
+    "@babel/preset-flow": "^7.18.6",
+    "@babel/preset-typescript": "^7.18.6",
+    "@types/jest": "^29.2.4",
+    "@types/node": "^18.11.16",
+    "@typescript-eslint/eslint-plugin": "^5.46.1",
+    "@typescript-eslint/parser": "^5.46.1",
+    "babel-jest": "^29.3.1",
+    "eslint": "^8.29.0",
+    "eslint-config-airbnb-base": "^15.0.0",
+    "eslint-config-airbnb-typescript": "^17.0.0",
+    "eslint-config-prettier": "^8.5.0",
+    "eslint-import-resolver-typescript": "^3.5.2",
+    "eslint-plugin-flowtype": "^8.0.3",
+    "eslint-plugin-import": "^2.26.0",
+    "eslint-plugin-prettier": "^4.2.1",
+    "flow-bin": "^0.196.0",
     "husky": ">=7.0.2",
-    "jest": "^27.2.0",
+    "jest": "^29.3.1",
     "lint-staged": ">=11.1.2",
-    "prettier": "^2.4.1",
-    "typescript": "^4.4.3"
+    "prettier": "^2.8.1",
+    "typescript": "^4.9.4"
   },
   "dependencies": {
-    "@babel/parser": "^7.15.7",
-    "@babel/runtime": "^7.15.4",
-    "@babel/traverse": "^7.15.4",
-    "@babel/types": "^7.15.6",
-    "@jest/types": "^27.1.1",
+    "@babel/parser": "^7.20.5",
+    "@babel/runtime": "^7.20.6",
+    "@babel/traverse": "^7.20.5",
+    "@babel/types": "^7.20.5",
+    "@jest/types": "^29.3.1",
     "core-js": "^3.17.3",
     "jest-snapshot": "^27.2.0"
   },

src/Runner.js

@@ -21,12 +21,14 @@ import {createProcess} from './Process';
 // passes out events when it understands what data is being
 // pass sent out of the process
 export default class Runner extends EventEmitter {
-  debugprocess: ChildProcess;
+  debugprocess: ?ChildProcess;
 
   outputPath: string;
 
+  // $FlowIgnore[value-as-type]
   workspace: ProjectWorkspace;
 
+  // $FlowIgnore[value-as-type]
   _createProcess: (workspace: ProjectWorkspace, args: Array<string>) => ChildProcess;
 
   watchMode: boolean;
@@ -39,6 +41,7 @@ export default class Runner extends EventEmitter {
 
   _exited: boolean;
 
+  // $FlowIgnore[value-as-type]
   constructor(workspace: ProjectWorkspace, options?: Options) {
     super();
 
@@ -97,17 +100,18 @@ export default class Runner extends EventEmitter {
     this.watchAll = watchAll;
 
     const args = this._getArgs();
-    this.debugprocess = this._createProcess(this.workspace, args);
-    this.debugprocess.stdout.on('data', (data: Buffer) => {
+    const debugprocess = this._createProcess(this.workspace, args);
+    this.debugprocess = debugprocess;
+    debugprocess.stdout.on('data', (data: Buffer) => {
       this._parseOutput(data, false);
     });
 
-    this.debugprocess.stderr.on('data', (data: Buffer) => {
+    debugprocess.stderr.on('data', (data: Buffer) => {
       // jest 23 could send test results message to stderr
       // see https://github.com/facebook/jest/pull/4858
       this._parseOutput(data, true);
     });
-    this.debugprocess.on('exit', (code: number | null, signal: string | null) => {
+    debugprocess.on('exit', (code: number | null, signal: string | null) => {
       this._exited = true;
 
       // this is mainly for backward compatibility, should be deprecated soon
@@ -117,12 +121,12 @@ export default class Runner extends EventEmitter {
       this.prevMessageTypes.length = 0;
     });
 
-    this.debugprocess.on('error', (error: Error) => {
+    debugprocess.on('error', (error: Error) => {
       this.emit('terminalError', `Process failed: ${error.message}`);
       this.prevMessageTypes.length = 0;
     });
 
-    this.debugprocess.on('close', (code: number | null, signal: string | null) => {
+    debugprocess.on('close', (code: number | null, signal: string | null) => {
       // this is mainly for backward compatibility, should be deprecated soon
       this.emit('debuggerProcessExit');
 
@@ -216,13 +220,15 @@ export default class Runner extends EventEmitter {
         // knowing this could leave orphan process...
         // eslint-disable-next-line no-console
         console.warn(
-          `failed to kill process group, this could leave some orphan process whose ppid=${this.debugprocess.pid}. error=`,
+          `failed to kill process group, this could leave some orphan process whose ppid=${
+            this.debugprocess?.pid || 'process-non-exist'
+          }. error=`,
           e
         );
-        this.debugprocess.kill();
+        this.debugprocess?.kill();
       }
     }
-    delete this.debugprocess;
+    this.debugprocess = undefined;
   }
 
   // eslint-disable-next-line class-methods-use-this
@@ -242,7 +248,7 @@ export default class Runner extends EventEmitter {
     return match ? match.messageType : messageTypes.unknown;
   }
 
-  doResultsFollowNoTestsFoundMessage() {
+  doResultsFollowNoTestsFoundMessage(): boolean {
     if (this.prevMessageTypes.length === 1) {
       return this.prevMessageTypes[0] === messageTypes.noTests;
     }

src/Settings.js

@@ -8,7 +8,7 @@
  */
 
 import type {Options} from './types';
-import ProjectWorkspace from './project_workspace';
+import type ProjectWorkspace from './project_workspace';
 import {createProcess} from './Process';
 
 type Glob = string;
@@ -30,7 +30,7 @@ type JestSettings = {
 };
 
 function parseSettings(text: string, debug: ?boolean = false): JestSettings {
-  const jsonPattern = new RegExp(/^[\s]*\{/gm);
+  const jsonPattern = /^[\s]*\{/gm;
   let settings = null;
 
   try {
@@ -62,6 +62,7 @@ function parseSettings(text: string, debug: ?boolean = false): JestSettings {
   };
 }
 
+// $FlowIgnore[value-as-type]
 export default function getSettings(workspace: ProjectWorkspace, options?: Options): Promise<JestSettings> {
   return new Promise((resolve, reject) => {
     const _createProcess = (options && options.createProcess) || createProcess;

src/Snapshot.js

@@ -9,7 +9,7 @@
  */
 
 import traverse from '@babel/traverse';
-import {buildSnapshotResolver, SnapshotResolver, utils, SnapshotData} from 'jest-snapshot';
+import {buildSnapshotResolver, type SnapshotResolver, type SnapshotData, utils} from 'jest-snapshot';
 import type {ProjectConfig} from '../types/Config';
 
 import {getASTfor} from './parsers/babel_parser';
@@ -49,16 +49,16 @@ const validParents = Object.assign(
   })
 );
 
-const isValidMemberExpression = (node) =>
+const isValidMemberExpression = (node: any) =>
   node.object && base[node.object.name] && node.property && decorators[node.property.name];
 
-const isDescribe = (node) =>
+const isDescribe = (node: any) =>
   describeVariants[node.name] || (isValidMemberExpression(node) && node.object.name === 'describe');
 
-const isValidParent = (parent) =>
+const isValidParent = (parent: any) =>
   parent.callee && (validParents[parent.callee.name] || isValidMemberExpression(parent.callee));
 
-const getArrayOfParents = (path) => {
+const getArrayOfParents = (path: any) => {
   const result = [];
   let parent = path.parentPath;
   while (parent) {
@@ -90,8 +90,10 @@ export default class Snapshot {
 
   _projectConfig: ?ProjectConfig;
 
+  // $FlowIgnore[value-as-type]
   snapshotResolver: ?SnapshotResolver;
 
+  // $FlowIgnore[value-as-type]
   _resolverPromise: Promise<SnapshotResolver>;
 
   constructor(parser: any, customMatchers?: Array<string>, projectConfig?: ProjectConfig) {
@@ -118,7 +120,7 @@ export default class Snapshot {
     }
 
     const Visitors = {
-      Identifier(path, found, matchers) {
+      Identifier(path: any, found: any, matchers: any) {
         if (matchers.indexOf(path.node.name) >= 0) {
           found.push({
             node: path.node,
@@ -145,6 +147,7 @@ export default class Snapshot {
     }));
   }
 
+  // $FlowIgnore[value-as-type]
   async _getSnapshotResolver(): Promise<SnapshotResolver> {
     if (!this.snapshotResolver) {
       await this._resolverPromise;
@@ -160,6 +163,7 @@ export default class Snapshot {
    * a SnapshotData object will be returned with all matched snapshots. If nothing matched, null will be returned.
    * @throws throws exception if the snapshot version mismatched or any other unexpected error.
    */
+  // $FlowIgnore[value-as-type]
   async getSnapshotContent(filePath: string, name: string | RegExp): Promise<string | SnapshotData | null> {
     const snapshotResolver = await this._getSnapshotResolver();
 
@@ -169,6 +173,7 @@ export default class Snapshot {
       return snapshots[name];
     }
     const regex = name;
+    // $FlowIgnore[value-as-type]
     const data: SnapshotData = {};
     Object.entries(snapshots).forEach(([key, value]) => {
       if (regex.test(key)) {

src/__tests__/parsers/babel_parser.test.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 /* eslint-disable @typescript-eslint/no-unsafe-call */
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
@@ -1012,6 +1013,21 @@ describe('parsers', () => {
         const itBlock = parseResult.itBlocks[0];
         assertBlock2(itBlock, 2, 11, 4, 13, 'should parse');
       });
+      it('https://github.com/jest-community/jest-editor-support/issues/96', () => {
+        const data = `
+        import { asMockedFunction, type AnyFunction } from '@whatever/jest-types';
+        test('a test', () => {
+          expect(true).toBe(true);
+        });
+      `;
+        const parseResult = parseFunction('whatever', data);
+        expect(parseResult.itBlocks.length).toEqual(1);
+
+        const name = 'a test';
+        const itBlock = parseResult.itBlocks[0];
+        assertBlock2(itBlock, 3, 9, 5, 11, name);
+        assertNameInfo(itBlock, name, 3, 15, 3, 20);
+      });
     });
   });
 });

src/__tests__/parsers/parser_nodes.test.js

@@ -53,6 +53,7 @@ describe('ParsedNode', () => {
   it('throws an error when adding an unknown child', async () => {
     const root = new ParsedNode('describe', 'a/b/c');
     expect(() => {
+      // $FlowIgnore[prop-missing]
       root.addChild('unknown');
     }).toThrow(TypeError);
   });

src/__tests__/process.test.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable @typescript-eslint/no-explicit-any */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 /* eslint-disable @typescript-eslint/no-unsafe-call */