How do I set shell that lazygit will use?

[Lippiece]

With recently added support of fish which I'm normally using, lazygit.nvim feature I always use (edit when hovering a line) is broken since the plugin probably uses bash.

How do I make lazygit use bash?

Screenshot

[Lippiece]

Here's a workaround:

os:
  shellFunctionsFile: ~/bin/set-shell-bash.fish

[ojsef39]

nice works, the only thing i noticed is that it opens it in a new "tab" or whatever you can call that

Nix homemanager code build from master

{ pkgs, ...}:
{
  programs = { 
    lazygit = {
      enable = true;
      package = pkgs.buildGoModule rec {
        pname = "lazygit";
        version = "master";
        src = pkgs.fetchFromGitHub {
          owner = "jesseduffield";
          repo = "lazygit";
          rev = "master";
          sha256 = "sha256-1+X/FyT6EzsbVBZsMrI5iVBcjv7mSGMEgc/JOqyfNWA=";
        };
        vendorHash = null;
        doCheck = false;
        ldflags = [ "-X main.version=${version}" "-X main.buildSource=nix" ];
        meta = with pkgs.lib; {
          description = "Simple terminal UI for git commands";
          homepage = "https://github.com/jesseduffield/lazygit";
          license = licenses.mit;
          mainProgram = "lazygit";
        };
      };
    };
  };
}

[stefanhaller]

Are you saying that this is now different from how it used to work before 0.49.0? As far as I can see, we are still sending the same commands to nvim as before.

I know next to nothing about nvim, so I'm afraid I can't help much with this, I'm just interested whether we changed the behavior on our side.

[ojsef39]

I know next to nothing about nvim, so I'm afraid I can't help much with this, I'm just interested whether we changed the behavior on our side.

I will report back tomorrow, maybe i'm just hallucinating :D

My work laptop is still on the old config with zsh instead of fish and so on, there i can check for sure.

[ojsef39]

I just checked again, and seems like i was wrong, that was just a plugin i use causing it to sometimes not open in that tab and that confused me. The main behaviour without the plugin on both systems is the new tab :)

[stefanhaller]

Glad to hear this, thanks for checking.

[stefanhaller]

This broke with #4385; in that PR I decided to use the new way of calling the shell not only for : commands and custom commands, but also for calling the editor. We had requests for this in the past (e.g. #2392 and #899 (comment)), so I thought it would be a good idea since it's easy.

I didn't realize that this breaks the nvim-remote edit preset when using fish, so maybe we should not use this custom shell logic for edit commands.

[Lippiece]

I see. No worries. Looking forward to the fix. And thanks for your work on this project!

[stefanhaller]

Fixed in #4506.