After testing BookMacster 1.17 in Mavericks

Author: jerrykrinock

SSYLaunchdGuy.h

@@ -169,6 +169,23 @@ __attribute__((visibility("default"))) @interface SSYLaunchdGuy : NSObject {
 + (BOOL)removeAgentsWithGlob:(NSString*)glob
 					 error_p:(NSError**)error_p ;
 
+/*
+ @brief    Returns the pid of the currently-running process launched in honor
+ of a given launchd label for the current user, or 0 if there is no such 
+ process currently running.
+
+ @details  This method relies on the 'list' subcommand of 'launchctl' returning
+ the three columns {pid, last exit status, label} as documented in the man 
+ page launchctl(1).  If that return is not as expected, this method logs a
+ message to stderr and returns 0.  Likewise if launchctl or grep don't exit
+ with status 0.
+ 
+ If you pass nil or a non-label string, returns 0 and does not log anything.
+ 
+ This method had a bug until BookMacster 1.17.  Prior to that, if your label's
+ last exit status was not 0, and the label's process was not current running,
+ this method would return the negative of that last exit status, instead of 0.
+ */
 + (pid_t)pidIfRunningLabel:(NSString*)label ;
 
 /*!

SSYLaunchdGuy.m

@@ -350,40 +350,67 @@ + (pid_t)pidIfRunningLabel:(NSString*)label {
 	NSInteger result ;
 	pid_t pid = 0 ;	
 
-	NSData* stdoutData = nil ;
-	NSError* error = nil ;
-	NSString* command = [NSString stringWithFormat:
-						 @"/bin/launchctl list | /usr/bin/grep %@",
-						 [self bashEscapementOfLabel:label]] ;
-	NSArray* arguments = [NSArray arrayWithObjects:
-						  @"-c",
-						  command,
-						  nil] ;
-	result = [SSYShellTasker doShellTaskCommand:@"/bin/sh"
-									  arguments:arguments
-									inDirectory:nil
-									  stdinData:nil
-								   stdoutData_p:&stdoutData
-								   stderrData_p:NULL
-										timeout:3.0
-										error_p:&error] ;
-	if ((result != 0) && error) {
-		NSLog(@"SSYLaunchdGuy Error 879-1417 label=%@  %@", label, error) ;
-	}
-	
-	if (stdoutData) {
-		NSString* response = [[NSString alloc] initWithData:stdoutData
-												   encoding:NSUTF8StringEncoding] ;
-		// Next line is defensive programming
-		NSString* trimmedResponse = [response stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]] ;
-        [response release] ;
-		NSArray* words = [trimmedResponse componentsSeparatedByString:@" "] ;
-		if ([words count] > 0) {
-			NSString* pidString = [words objectAtIndex:0] ;
-            pid = [pidString intValue] ;
-		}
-	}
-	
+	if ([label length] > 0) {
+        NSData* stdoutData = nil ;
+        NSError* error = nil ;
+        NSString* commandString = [NSString stringWithFormat:
+                                   @"/bin/launchctl list | /usr/bin/grep %@",
+                                   [self bashEscapementOfLabel:label]] ;
+        NSArray* arguments = [NSArray arrayWithObjects:
+                              @"-c",  // Tells sh: Read commands from next argument
+                              commandString,
+                              nil] ;
+        result = [SSYShellTasker doShellTaskCommand:@"/bin/sh"
+                                          arguments:arguments
+                                        inDirectory:nil
+                                          stdinData:nil
+                                       stdoutData_p:&stdoutData
+                                       stderrData_p:NULL
+                                            timeout:3.0
+                                            error_p:&error] ;
+        if ((result != 0) && error) {
+            NSLog(@"SSYLaunchdGuy Error 879-1417 label=%@  %@", label, error) ;
+        }
+        
+        if (stdoutData) {
+            NSString* response = [[NSString alloc] initWithData:stdoutData
+                                                       encoding:NSUTF8StringEncoding] ;
+            NSString* trimmedResponse = [response stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]] ;
+            /*
+             The following line was fixed in BookMacster 1.17 so that it works
+             if fields are separated by tabs (as they are in Mac OS X 10.8)
+             instead of spaces.  Maybe they were spaces in an earlier OS X
+             version?  Anyhow, we handle either now.
+             */
+            NSArray* words = [trimmedResponse componentsSeparatedByCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]] ;
+            /*
+             If the 3 "words" (pid, <last exit status>, label) printed by
+             launchctl are separated by multiple spaces instead of tabs,
+             'words' will contain bunches of empty strings in addition to these
+             3 actual "words".  This is because
+             -componentsSeparatedByCharactersInSet: does not coalesce
+             consecutive separators.  However, since we are only interested in
+             the first object in words (the pid), we still get it OK.
+             */
+            if ([words count] > 2) {   // Was "> 0" until BookMacster 1.17
+                NSString* pidString = [words objectAtIndex:0] ;
+                pid = [pidString intValue] ;
+                /* If the label does not have a running process, launchctl will
+                 signify that by a dash ("-") and hence pidString will be "-",
+                 and hence we'll get pid=0 as desired, because -intValue
+                 "Returns 0 if the receiver doesn’t begin with a valid decimal
+                 text representation of a number." */
+            }
+            else if ([words count] > 1){
+                NSLog(@"SSYLaunchdGuy Error 879-1418 label=%@  response=\"%@\"", label, response) ;
+            }
+            else {
+                // Expected if the given label is not registered with launchd.
+            }
+            [response release] ;
+        }
+    }
+    
 	return pid ;
 }
 

SSYMOCManager.h

@@ -56,7 +56,7 @@
  
  This method retains a reference to the managed object context (in any of the three MOCDics).
  To avoid leaks or retain cycles, send a 
- -releaseManagedObjectContext: message whenever a managed object context returned from this
+ +destroyManagedObjectContext: message whenever a managed object context returned from this
  method is no longer needed.
  @param    type  NSSQLiteStoreType or NSInMemoryStoreType.
  @param    owner  If a new managed object context must be created, an arbitrary object which
@@ -93,7 +93,7 @@
  for the managed objects.
  
  This method retains the -document parameter until it receives a corresponding
- +releaseManagedObjectContext message, so be careful or you will create retain cycles.
+ +destroyManagedObjectContext message, so be careful or you will create retain cycles.
  This method will, however, *replace* its record for a particular document if you later
  send this message again for the same document with a new or same managedObjectContext.
  @param    document  The document which owns the managed object context
@@ -133,11 +133,25 @@
  needed, in order to avoid memory leaks in your program.  To avoid retain cycles,
  don't do it in -dealloc.  Put it in a method which runs prior to -dealloc.
  It is OK to send this message more than once; further invocations will no-op.
+ 
+ However, note that SSYMOCManager does not have a retain count mechanism.  That
+ is why this method is named "destroy…" instead of "release…".  If more than one
+ of your objects could be using the subject managed object context, it is your
+ responsibility to not send this message until all such objects no longer need
+ it.
  @param    managedObjectContext  The managed object context to be removed.
  @return  YES if an entry with the given managed object context was found and removed,
  otherwise NO. 
 */
-+ (BOOL)releaseManagedObjectContext:(NSManagedObjectContext*)managedObjectContext ;
++ (BOOL)destroyManagedObjectContext:(NSManagedObjectContext*)managedObjectContext ;
+
+/*@brief    Removes any managed object context with a give identifier,
+which would be returned by -managedObjectContextType:::::, from the
+ receiver's instance's data.
+
+@details  Ditto the details from +destroyManagedObjectContext:.
+ */
++ (void)destroyManagedObjectContextWithIdentifier:(NSString*)identifier ;
 
 /*!
  @brief    Deletes the local store file on disk for an sqlite store with a given

SSYMOCManager.m

@@ -8,6 +8,8 @@
 #import "SSYPersistentDocumentMultiMigrator.h"
 #import "NSManagedObjectContext+Cheats.h"
 #import "NSError+DecodeCodes.h"
+#import "NSObject+MoreDescriptions.h"
+
 
 NSString* const constKeyMOC = @"moc" ;
 NSString* const constKeyOwner = @"owr" ;
@@ -24,40 +26,6 @@
 //    -autorelease
 static SSYMOCManager* sharedMOCManager = nil ;
 
-#if DEBUG
-
-@interface NSCountedSet (SSYMOCManagerHelp)
-
-- (NSString*)shortDescription ;
-
-@end
-
-@implementation NSCountedSet (SSYMOCManagerHelp)
-
-- (NSString*)shortDescription {
-	NSMutableString* desc = [NSMutableString string] ;
-	for (id object in self) {
-		[desc appendFormat:
-		 @"%@ [%ld],",
-		 [object shortDescription],
-		 (long)[self countForObject:object]] ;
-	}
-
-	// Delete the trailing comma
-	if ([desc length] > 0) {
-		[desc deleteCharactersInRange:NSMakeRange([desc length] - 1, 1)] ;
-	}
-	else {
-		[desc appendString:@"<Empty Set>"] ;
-	}
-
-	return [[desc copy] autorelease] ;
-}
-
-@end
-
-#endif
-
 
 @interface SSYMOCManager (PrivateHeader)
 
@@ -338,7 +306,7 @@ - (NSManagedObjectContext*)managedObjectContextType:(NSString*)type
 																						momdName:momdName
 																						 error_p:error_p] ;
 		if (coordinator) {
-			managedObjectContext = [[NSManagedObjectContext alloc] init] ;
+            managedObjectContext = [[NSManagedObjectContext alloc] init] ;
 			[managedObjectContext setPersistentStoreCoordinator:coordinator] ;
 			if (!owner_) {
 				// A no-owner moc is a "cheap" moc.
@@ -355,6 +323,7 @@ - (NSManagedObjectContext*)managedObjectContextType:(NSString*)type
 						forKey:identifier] ;
 
 			[managedObjectContext release] ; // balances +alloc, above
+            ;
 		}
 	}
 
@@ -424,7 +393,13 @@ - (id)ownerOfManagedObjectContext:(NSManagedObjectContext*)managedObjectContext
 	return answer ;
 }
 
-- (BOOL)releaseManagedObjectContext:(NSManagedObjectContext*)managedObjectContext
+- (void)destroyManagedObjectContextWithIdentifier:(NSString*)identifier {
+	[[self inMemoryMOCDics] removeObjectForKey:identifier] ;
+    [[self sqliteMOCDics] removeObjectForKey:identifier] ;
+    [[self docMOCDics] removeObjectForKey:identifier] ;
+}
+
+- (BOOL)destroyManagedObjectContext:(NSManagedObjectContext*)managedObjectContext
 					   inDictionary:(NSMutableDictionary*)dictionary {
 	NSString* removeeIdentifier = nil ;
 	for (NSString* identifier in dictionary) {
@@ -442,17 +417,17 @@ - (BOOL)releaseManagedObjectContext:(NSManagedObjectContext*)managedObjectContex
 	return (removeeIdentifier != nil) ;
 }	
 
-- (BOOL)releaseManagedObjectContext:(NSManagedObjectContext*)managedObjectContext {
+- (BOOL)destroyManagedObjectContext:(NSManagedObjectContext*)managedObjectContext {
 	BOOL didDo = NO ;
-	didDo = [self releaseManagedObjectContext:managedObjectContext
+	didDo = [self destroyManagedObjectContext:managedObjectContext
 								inDictionary:[self inMemoryMOCDics]] ;
 	if (!didDo) {
-		didDo = [self releaseManagedObjectContext:managedObjectContext
+		didDo = [self destroyManagedObjectContext:managedObjectContext
 									inDictionary:[self sqliteMOCDics]] ;
 	}
 
 	if (!didDo) {
-		didDo = [self releaseManagedObjectContext:managedObjectContext
+		didDo = [self destroyManagedObjectContext:managedObjectContext
 									inDictionary:[self docMOCDics]] ;
 	}
 
@@ -484,8 +459,12 @@ + (id)ownerOfManagedObjectContext:(NSManagedObjectContext*)managedObjectContext
 	return [[self sharedMOCManager] ownerOfManagedObjectContext:managedObjectContext] ;
 }
 
-+ (BOOL)releaseManagedObjectContext:(NSManagedObjectContext*)managedObjectContext {
-	return [[self sharedMOCManager] releaseManagedObjectContext:managedObjectContext] ;
++ (BOOL)destroyManagedObjectContext:(NSManagedObjectContext*)managedObjectContext {
+	return [[self sharedMOCManager] destroyManagedObjectContext:managedObjectContext] ;
+}
+
++ (void)destroyManagedObjectContextWithIdentifier:(NSString*)identifier {
+	[[self sharedMOCManager] destroyManagedObjectContextWithIdentifier:identifier] ;
 }
 
 + (void)removeSqliteStoreForIdentifier:(NSString*)identifier {

SSYManagedObject.m

@@ -311,7 +311,7 @@ - (void)postWillSetNewValue:(id)value
         [(SSYDooDooUndoManager*)[[self owner] undoManager] beginAutoEndingUndoGrouping] ;
 	}
 
-	NSDictionary* info = [NSDictionary dictionaryWithObjectsAndKeys:
+    NSDictionary* info = [NSDictionary dictionaryWithObjectsAndKeys:
 						  key, constKeySSYChangedKey,
 						  value, constKeyNewValue,  // May be nil, so keep this last!
 						  nil] ;

SSYOperationQueue.m

@@ -234,7 +234,6 @@ - (void)observeValueForKeyPath:(NSString*)keyPath
             id activity = [self noAppNapActivity] ;
             if (activity) {
                 [[NSProcessInfo processInfo] endActivity:activity];
-                /*SSYDBL*/ NSLog(@"Ended no-app-nap activity=%@", activity) ;
             }
 #endif
 
@@ -259,7 +258,6 @@ - (void)observeValueForKeyPath:(NSString*)keyPath
 			// KVO notifications are coalesced.
 
 #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1090
-#warning "Built for 10.9"
             // Being built with Mac OS X 10.9 or later SDK
             if ([[NSProcessInfo processInfo] respondsToSelector:@selector(beginActivityWithOptions:reason:)]) {
                 // Running in Mac OS X 10.9 or later
@@ -280,7 +278,6 @@ - (void)observeValueForKeyPath:(NSString*)keyPath
                                     [[NSDate date] geekDateTimeString]] ;
                 id activity = [[NSProcessInfo processInfo] beginActivityWithOptions:NSActivityAutomaticTerminationDisabled
                                                                              reason:reason] ;
-                /*SSYDBL*/ NSLog(@"Suspended app nap with activity=%@ for reason: %@", activity, reason) ;
                 [self setNoAppNapActivity:activity] ;
             }
 #endif