• Refactored SSYArrayController into a superclass which only has the workaround for Apple Bug Apple Bug ID 7827354 which was closed as a duplicate of 3404770.

Author: jerrykrinock

SSYArrayController.h

@@ -7,6 +7,8 @@
 
 @end
 
+#import "SSYMoreObserveableArrayController.h"
+
 /*!
  @brief    An array controller which supports reordering of objects by the user,
  better-behaved -remove:, a new "add" method which behaves better than -add:,
@@ -116,7 +118,7 @@
  font size to be set in the table view's cell.  It does this by implementing
  the delegate method tableView:willDisplayCell:forTableColumn:row:.
  */
-@interface SSYArrayController : NSArrayController {
+@interface SSYArrayController : SSYMoreObserveableArrayController {
     id m_parentObject ;
     NSString* m_parentObjectKey ;
 	NSString* m_contentKey ;
@@ -133,9 +135,6 @@
 @property (copy) NSString* contentKey ;
 @property (assign) CGFloat tableFontSize ;
 
-/* To work around bug in NSArrayController, Apple Bug ID 7827354 which was
- closed as a duplicate of 3404770. */
-@property (assign, readonly) BOOL hasSelection ;
 
 /*!
  @brief    Adds a new item below the current selection, or at the 

SSYArrayController.m

@@ -14,11 +14,6 @@ @interface SSYArrayController ()
 @end
 
 
-@interface SSYArrayController ()
-
-@property (assign) BOOL hasSelection ;
-
-@end
 
 @implementation SSYArrayController
 
@@ -28,12 +23,8 @@ @implementation SSYArrayController
 @synthesize pendingObjectsIndexSet = m_pendingObjectsIndexSet ;
 @synthesize lineHeightMultiplier = m_lineHeightMultiplier ;
 @synthesize tableFontSize = m_tableFontSize ;
-@synthesize hasSelection = m_hasSelection ;
 
-- (void)dealloc {
-	[self removeObserver:self
-			  forKeyPath:@"selectedObjects"] ;
-	
+- (void)dealloc {	
 	[m_parentObjectKey release] ;
 	[m_contentKey release] ;
 	[m_pendingObjectsIndexSet release] ;
@@ -55,52 +46,8 @@ - (void)awakeFromNib {
 							 nil] ;
     [tableView registerForDraggedTypes:draggedTypes] ;
     [tableView setAllowsMultipleSelection:YES] ;
-
-	[self addObserver:self
-		   forKeyPath:@"selectedObjects"
-			  options:0
-			  context:NULL] ;
 }
 
-- (void)observeValueForKeyPath:(NSString *)keyPath
-					  ofObject:(id)object
-						change:(NSDictionary *)change
-					   context:(void *)context {
-	if ([keyPath isEqualToString:@"selectedObjects"]) {
-#if 0
-#warning observing changes to selected objects for Mythical Deep Observer
-		NSLog(@"1681: Some sleazeball changed selection: %@", [change shortDescription]) ;
-		NSLog(@"continuing") ;
-#endif
-		NSInteger selectionCount = [[self selectedObjects] count] ;
-		[self setHasSelection:(selectionCount > 0)] ;
-	}
-
-//	NSTimeInterval startTime = [NSDate timeIntervalSinceReferenceDate] ;
-
-	[super observeValueForKeyPath:keyPath
-						 ofObject:object
-						   change:change
-						  context:context] ;
-
-/*
- NSTimeInterval thisTime = [NSDate timeIntervalSinceReferenceDate] - startTime ;
-	if ([object isKindOfClass:[Starkoid class]]) {
-		starkoidTime += thisTime ;
-		NSLog(@"starkoidTime = %0.3f", starkoidTime) ;
-	}
-	else if ([object isKindOfClass:[SSYArrayController class]]) {
-		arrayControllerTime += thisTime ;
-		NSLog(@"arrayControllerTime = %0.3f", arrayControllerTime) ;
-	}
-	else {
-		otherTime += thisTime ;
-		NSLog(@"otherTime = %0.3f", otherTime) ;
-	}
-*/
-}
-
-
 - (BOOL)     tableView:(NSTableView *)tv
   writeRowsWithIndexes:(NSIndexSet*)indexes
 		  toPasteboard:(NSPasteboard*)pboard {
@@ -114,8 +61,6 @@ - (BOOL)     tableView:(NSTableView *)tv
     return YES ;
 }
 
-
-
 - (NSDragOperation)tableView:(NSTableView*)tv
 				validateDrop:(id <NSDraggingInfo>)info
 				 proposedRow:(NSInteger)targetRow

SSYMoreObserveableArrayController.h

@@ -0,0 +1,14 @@
+#import "SSYMoreObserveableArrayController.h"
+
+@interface SSYMoreObserveableArrayController : NSArrayController
+
+/*!
+ @brief    Workaround for Apple Bug ID 7827354, which was closed as a duplicate
+ of 3404770, in NSArrayController
+ 
+ @details  Provides a -hasSelection property which actually works.
+ */
+
+@property (assign, readonly) BOOL hasSelection ;
+
+@end

SSYMoreObserveableArrayController.m

@@ -0,0 +1,49 @@
+#import "SSYMoreObserveableArrayController.h"
+
+@interface SSYMoreObserveableArrayController ()
+
+@property (assign) BOOL hasSelection ;
+
+@end
+
+
+@implementation SSYMoreObserveableArrayController
+
+- (void)dealloc {
+    [self removeObserver:self
+              forKeyPath:@"selectedObjects"] ;
+    
+#if !__has_feature(objc_arc)
+    [super dealloc] ;
+#endif
+}
+
+- (void)awakeFromNib {
+    // Per Discussion in documentation of -[NSObject respondsToSelector:].
+    // the superclass name in the following must be hard-coded.
+    if ([NSArrayController instancesRespondToSelector:@selector(awakeFromNib)]) {
+        [super awakeFromNib] ;
+    }
+    
+    [self addObserver:self
+           forKeyPath:@"selectedObjects"
+              options:0
+              context:NULL] ;
+}
+
+- (void)observeValueForKeyPath:(NSString *)keyPath
+                      ofObject:(id)object
+                        change:(NSDictionary *)change
+                       context:(void *)context {
+    if ([keyPath isEqualToString:@"selectedObjects"]) {
+        NSInteger selectionCount = [[self selectedObjects] count] ;
+        [self setHasSelection:(selectionCount > 0)] ;
+    }
+    
+    [super observeValueForKeyPath:keyPath
+                         ofObject:object
+                           change:change
+                          context:context] ;
+}
+
+@end