More tweaks to the way SSYAlert comes and goes.

Author: jerrykrinock

SSYAlert.m

@@ -770,13 +770,12 @@ - (IBAction)clickedButton:(id)sender {
 	if ([self clickTarget]) {
         [[self clickTarget] recklessPerformSelector:[self clickSelector]
                                              object:self] ;
-		[self setIsDoingModalDialog:NO] ;
-	}
-	
-	if ([self checkboxState] == NSOnState) {
-		[[self checkboxInvocation] invoke] ;
 	}
 
+    if ([self checkboxState] == NSOnState) {
+        [[self checkboxInvocation] invoke] ;
+    }
+    
     if (!m_dontGoAwayUponButtonClicked) {
         [self goAway] ;
     }
@@ -1262,7 +1261,8 @@ - (void)setCheckboxTitle:(NSString*)title {
 	}
 }
 
-- (void)addOtherSubview:(NSView*)subview atIndex:(NSInteger)index {
+- (void)addOtherSubview:(NSView*)subview
+                atIndex:(NSInteger)index {
     if (index > [[self otherSubviews] count]) {
         index = [[self otherSubviews] count] ;
     }

SSYListPicker.m

@@ -94,7 +94,6 @@ - (void)userPickFromList:(NSArray*)displayNames
 	[alert setIconStyle:SSYAlertIconInformational] ;
 	[alert setClickTarget:self] ;
 	[alert setClickSelector:@selector(handleClickInAlert:)] ;
-	[alert setDontGoAwayUponButtonClicked:YES] ;
 	// I think this was added in BookMacster 1.7.3 or, more likely, 1.8.  I forgot why, except that it was definitely needed…
 	[NSApp activateIgnoringOtherApps:YES] ;
 	NSMutableDictionary* didEndInfo = [NSMutableDictionary dictionary] ;
@@ -146,9 +145,7 @@ - (void)handleClickInAlert:(SSYAlert*)alert {
 	NSDictionary* clickDic = [alert clickObject] ;
 
 	if (done) {
-		[alert goAway] ;
-		
-		// Needed to break retain cycle:
+        // Needed to break retain cycle, or possibly no longer necessary?
 		[self setAlert:nil] ;
 	}