Phase 2 of Fixing Worker To Handle Asynchronous Return of Pajara For Preflightling Safari Bookmarks Hash. This tests OK with my usual "change in bookmark in Chrome", so I think I have not broken anything yet.

• In the worker1() function, all of the two dozen or so goto have been removed, and it has been renamed to workerSetup().
• The old clean-up code after the run loop has been moved into new function workerEnd1()
• The code between the first old goto label `end` and the second goto label `endNow` has been moved into new function workerEnd2()
• The code after the second old goto label `endNow` has been moved into new function workerEnd3()

All of the local variables in the outer scope of the old main() are now global variables, as are three new BOOLs shouldSkipEnd1, shouldSkipEnd2 and shouldSkipEnd3 which provide the skips formerly provided by the gotos.

The run loop will exit immediately if workerSetup took any of its early returns.  Next, I think I need to get the run loop running earlier.

Author: jerrykrinock

SSYUserInfo.h

@@ -47,13 +47,14 @@ __attribute__((visibility("default"))) @interface SSYUserInfo : NSObject {
 */
 + (NSString*)consoleUserNameAndUid_p:(uid_t*)uid_p
 							   gid_p:(gid_t*)gid_p ;
-
 /*!
  @brief    Returns a date object representing the time that the current user
  logged in to the macOS user account currently showing in the GUI
 
- @result   A NSDate, or upon failure, if assertions are not active, nil
+ @param    error_p  Pointer which will, upon return, if an error occurred and
+ said pointer is not NULL, point to an NSError describing said error.
+ @result   A NSDate, or upon failure, nil
  */
-+ (NSDate*)whenThisUserLoggedIn;
++ (NSDate*)whenThisUserLoggedInError_p:(NSError**)error_p ;
 
 @end

SSYUserInfo.m

@@ -46,29 +46,42 @@ + (NSString*)consoleUserNameAndUid_p:(uid_t*)uid_p
 	return [name autorelease] ;
 }
 
-+ (NSDate*)whenThisUserLoggedIn {
++ (NSDate*)whenThisUserLoggedInError_p:(NSError**)error_p {
     /* See:
      https://www.freebsd.org/cgi/man.cgi?query=getutxent&sektion=3
      */
     NSString* targetUser = (NSString*)CFBridgingRelease(SCDynamicStoreCopyConsoleUser(NULL, NULL, NULL)) ;
-    struct utmpx* record_p;
+    struct utmpx* entry_p;
     /* getutxent gets the entire history of UTX entries.  By passing 0 in the
      following line, we tell it to give us the most recent entries first. */
     setutxent_wtmp(0);
     NSDate* date = nil;
-    while (!date && (record_p = getutxent_wtmp()) != NULL) {
-        if (record_p->ut_type == USER_PROCESS) {
-            /* In addition to macOS GUI logins, there are also UTX records for
+    NSInteger countOfEntries = 0;
+    NSInteger countOfUserEntries = 0;
+    NSInteger countOfConsoleUserEntries = 0;
+    NSInteger countOfThisConsoleUserEntries = 0;
+    NSString* user = nil;
+    NSMutableArray* lines = [NSMutableArray new];
+    while (!date && (entry_p = getutxent_wtmp()) != NULL) {
+        countOfEntries++;
+        if (entry_p->ut_type == USER_PROCESS) {
+            countOfUserEntries++;
+            /* In addition to macOS GUI logins, there are also UTX entries for
              other logins such as Terminal.app tabs.  These are
              differentiated as different "line" types.  For the macOS GUI login
              which we want, the line type is "console". */
-            NSString* line = [NSString stringWithUTF8String:record_p->ut_line];
+            NSString* line = [NSString stringWithUTF8String:entry_p->ut_line];
+            if (line) {
+                [lines addObject:line];
+            }
             if ([line isEqualToString:@"console"]) {
+                countOfConsoleUserEntries++;
                 /* Finally, of course, we are only interested in logins of the
                  current macOS user. */
-                NSString* user = [NSString stringWithUTF8String:record_p->ut_user];
+                user = [NSString stringWithUTF8String:entry_p->ut_user];
                 if ([user isEqualToString:targetUser]) {
-                    time_t unixTime = record_p->ut_tv.tv_sec;
+                    countOfThisConsoleUserEntries++;
+                    time_t unixTime = entry_p->ut_tv.tv_sec;
                     date = [NSDate dateWithTimeIntervalSince1970:unixTime];
                     break;
                 }
@@ -77,7 +90,21 @@ + (NSDate*)whenThisUserLoggedIn {
     };
     endutxent_wtmp();
 
-    NSAssert(date, @"Could not decode UTX record");
+    if (!date && error_p) {
+        NSError* error = [NSError errorWithDomain:@"SSYUserInfoErrorDomain"
+                                             code:948308
+                                         userInfo:@{
+                                                    NSLocalizedDescriptionKey: @"SSYUserInfo could not find `%@` console UTX entry",
+                                                    @"entries count": [NSNumber numberWithInteger:countOfEntries],
+                                                    @"user entries count": [NSNumber numberWithInteger:countOfUserEntries ],
+                                                    @"console user entries count": [NSNumber numberWithInteger:countOfConsoleUserEntries ],
+                                                    @"this console user entries count": [NSNumber numberWithInteger:countOfThisConsoleUserEntries ],
+                                                    @"lines": lines
+                                                    }];
+        *error_p = error;
+    }
+
+    [lines release];
     return date;
 }