• Added method +[SSYVersionTriplet versionTripletFromBundle:]

•  Using that new method, made +[SSYAppInfo calculateUpgradeState] more reliable, because it now gets the current version from the bundle's Info.plist directly instead of NSWorkspace, which may find a different instance of the app with a different version number if more than one instance are installed on the system.

Author: jerrykrinock

SSYAppInfo.m

@@ -87,7 +87,7 @@ - (void)calculateUpgradeState {
     [self setUpgradeState:upgradeState] ;
     if ([self upgradeState] != SSYCurrentRev) {
         // Get a nice, clean, filtered versionString of the form "major.minor.bugFix" using SSVersionTriplet methods
-        SSYVersionTriplet* currentVersionTriplet = [SSYVersionTriplet versionTripletFromBundleIdentifier:[[NSBundle mainAppBundle] bundleIdentifier]] ;
+        SSYVersionTriplet* currentVersionTriplet = [SSYVersionTriplet versionTripletFromBundle:[NSBundle mainAppBundle]] ;
         NSString* currentVersionString = [currentVersionTriplet string] ;
 
         // Record currently-launched version into prefs
@@ -124,4 +124,4 @@ + (void)calculateUpgradeState {
 }
 
 
-@end
+@end

SSYVersionTriplet.h

@@ -82,14 +82,16 @@ typedef struct SSYVersionStruct_struct SSYVersionStruct ;
  */
 + (SSYVersionTriplet*)versionTripletFromString:(NSString*)versionString ;
 
++ (SSYVersionTriplet*)versionTripletFromBundle:(NSBundle*)bundle ;
+
 /*!
  @brief    Returns an autoreleased version triplet from a bundle
  @details  Version number string is found as described in 
  rawVersionTripletFromBundleIdentifier: and then version numbers in triplet are parsed
  as described in versionTripletFromString:
  
  @details  This function is not reliable because it relies on -rawVersionStringFromBundleIdentifier
- which is also not reliable.  If you've got the bundle, use +rawVersionStringFromBundle: instead.
+ which is also not reliable.  If you've got the bundle, use +versionTripletFromBundle: instead.
  @param    bundleIdentifier The bundle identifier of the target bundle
  @result   An autoreleased version triplet, or nil. 
  */

SSYVersionTriplet.m

@@ -77,6 +77,11 @@ + (SSYVersionTriplet*)versionTripletFromString:(NSString*)versionString {
 	return versionTriplet ;
 }
 
++ (SSYVersionTriplet*)versionTripletFromBundle:(NSBundle*)bundle {
+    NSString* versionString = [self rawVersionStringFromBundle:bundle] ;
+    return [self versionTripletFromString:versionString] ;
+}
+
 + (SSYVersionTriplet*)versionTripletFromBundleIdentifier:(NSString*)bundleIdentifier {
 	NSString* versionString = [self rawVersionStringFromBundleIdentifier:bundleIdentifier] ;
 	return [self versionTripletFromString:versionString] ;
@@ -210,4 +215,4 @@ + (NSString*)cleanVersionStringFromBundleIdentifier:(NSString*)bundleIdentifier
 	return [vt string] ;
 }
 
-@end
+@end