The Lazy Data Source seems to all work now, but tests are still incomplete. Many bugs in it were fixed by these changes:

• Explained in comments how -[ContentOutlineView outlineView:toolTipForCell:rect:tableColumn:item:mouseLocation:] overrides -[BkmxDocViewController
 tableView:toolTipForCell:rect:tableColumn:row:mouseLocation:]

• The noteChangedChildrenForStark: kludgey chain of drill-down methods has now been replaced by SSYManagedTreeChildrenChangedNotification.

• Added declaration of -[NSOutlineView itemAtRow:] to BkmxOutlineView.h to fix nonsense incorrect Xcode warnings that NSOutlineView does not implement this.

• More rework to the -checkAllProxies: mechanisms.

• Reworked how proxies are created.

• No longer leaks m_proxies and m_rootProxies

• Added kludge so that ContentOutlineView scrolls to the top now (-1 row - 1 point) in NSTableView (Scrolling)

• Reworked ContentProxy to handle dirty values in general instead of just dirty children, and replaced method -ensureChildren method -ensureDeeplyAndRegardlessly:

• Combined -setIndex: and -setParent: custom setters from Stark class into SSYManagedTreeObject.  Previously, the latter did not work because it was overridden by the former!

• Officially removed 0[Stark stealthilySetIndex:], which has not been used in recent commits.

Author: jerrykrinock

SSYManagedTreeObject.h

@@ -5,6 +5,9 @@
 extern NSString* const constKeyChildren ;
 extern NSString* const constKeyParent ;
 
+extern NSString* const SSYManagedTreeObjectKey ;
+extern NSString* const SSYManagedTreeChildrenChangedNotification ;
+
 /*!
  @brief    A subclass of SSYManagedObject which has 'parent'
  'children' and 'index' properties, so that it can be used as

SSYManagedTreeObject.m

@@ -5,6 +5,10 @@
 
 NSString* const constKeyChildren = @"children" ;
 NSString* const constKeyParent = @"parent" ;
+
+NSString* const SSYManagedTreeObjectKey = @"SSYManagedTreeObjectKey" ;
+NSString* const SSYManagedTreeChildrenChangedNotification = @"SSYManagedTreeChildrenChangedNotification" ;
+
 /*
  See note on DropboxFalseStart below
  // NodeId was going to be needed because, when adding a new bookmark
@@ -113,7 +117,7 @@ - (void)handleWillSetNewChildren:(NSSet*)newValue {
 /* Testing indicates that this method can be invoked, and children can by
  mutated, without invoking -setChildren: or any other setter.  In other words,
  this method seems to be an independent value-changer.  Therefore, the following
- override is necessary.  It was added in BookMacster 1.12.7. */
+ override *is* necessary.  It was added in BookMacster 1.12.7. */
 - (NSMutableSet*)mutableSetValueForKey:(NSString *)key {
     if ([key isEqualToString:constKeyChildren]) {
         [self forgetCachedChildrenOrdered];
@@ -184,16 +188,25 @@ - (void)setIndex:(NSNumber*)newValue  {
 	// In order to avoid registering undo and unnecessarily dirtying the dot,
 	// we only do the overwrite if there was a substantive change.
 	// (Note that current or new value can be nil.)
-	if ([NSObject isEqualHandlesNilObject1:[self index]
+	if (![NSObject isEqualHandlesNilObject1:[self index]
 									object2:newValue]) {
-		return ;
-	}
+        [self postWillSetNewValue:newValue
+                           forKey:constKeyIndex] ;
+        [self willChangeValueForKey:constKeyIndex] ;
+        [self setPrimitiveIndex:newValue] ;
+        [self didChangeValueForKey:constKeyIndex] ;
+
+        SSYManagedTreeObject* parent = [self parent] ;
+        if (parent) {
+            // The order of the following two statements must be as is:
+            [[self parent] forgetCachedChildrenOrdered] ;
+            [[NSNotificationCenter defaultCenter] postNotificationName:SSYManagedTreeChildrenChangedNotification
+                                                                object:[self owner]
+                                                              userInfo:[NSDictionary dictionaryWithObject:[self parent]
+                                                                                                   forKey:SSYManagedTreeObjectKey]] ;
+        }
+    }
 
-	[self postWillSetNewValue:newValue
-					   forKey:constKeyIndex] ;
-	[self willChangeValueForKey:constKeyIndex] ;
-    [self setPrimitiveIndex:newValue] ;
-    [self didChangeValueForKey:constKeyIndex] ;
 }
 
 - (NSInteger)indexValue {
@@ -221,7 +234,7 @@ - (NSArray*)childrenOrdered {
     if (!m_cachedChildrenOrdered) {
         m_cachedChildrenOrdered = [[[self children] arraySortedByKeyPath:constKeyIndex] retain] ;
     }
-    
+
     // arrayWithArray was added in BookMacster 1.12.8 to fix crashes which
     // were occuring in various methods when m_cachedChildrenOrdered was
     // changed.  I also removed -arrayWithArray in several methods where the
@@ -313,13 +326,25 @@ - (NSInteger)numberOfChildren {
 }
 
 // This is required to trigger -[BkmxDoc objectWillChangeNote:]
-- (void)setParent:(SSYManagedTreeObject*)newValue  {
-	[self postWillSetNewValue:newValue
-					   forKey:constKeyParent] ;
-	[self willChangeValueForKey:constKeyParent] ;
-    [self setPrimitiveParent:newValue] ;
-    [self didChangeValueForKey:constKeyParent] ;
-	
+- (void)setParent:(SSYManagedTreeObject*)newParent  {
+    if (![NSObject isEqualHandlesNilObject1:[self index]
+                                    object2:newParent]) {
+        [self postWillSetNewValue:newParent
+                           forKey:constKeyParent] ;
+
+        [self willChangeValueForKey:constKeyParent] ;
+        [self setPrimitiveParent:newParent] ;
+        [self didChangeValueForKey:constKeyParent] ;
+        
+        if (newParent) {
+            // The order of the following two statements must be as is:
+            [newParent forgetCachedChildrenOrdered] ;
+            [[NSNotificationCenter defaultCenter] postNotificationName:SSYManagedTreeChildrenChangedNotification
+                                                                object:[self owner]
+                                                              userInfo:[NSDictionary dictionaryWithObject:newParent
+                                                                                                   forKey:SSYManagedTreeObjectKey]] ;
+        }
+    }
 }
 
 /*