• Greatly simplified SSYDragDestinationTextView, which was full of crap. I think that most of what I was doing when I wrote that code many years ago was built into NSTextView, but I didn't know how to use it.

•  Removed patch for OS X 10.3.

Author: jerrykrinock

Diff for: SSYDragDestinationTextView.h

@@ -1,37 +1,18 @@
 #import <Cocoa/Cocoa.h>
 
-/*
- This class implements most of the NSDraggingDestination protocol,
- making it a little easier to make any NSTextView a dragging destination.
- 
- Things which must be done elsewhere:
- 
- - Somewhere, 
-		- send me -unregisterDraggedTypes, followed by 
-		    -registerForDraggedTypes: to the dragging destination NSView.
-        - If scrolling is desired, send configureScrollingHorzontal:vertical
-    Suggestions: Do these in a window controller's -awakeFromNib
-
- -	Dragging destination NSView must have a delegate, or be in a window with a delegate,
-    which implements the SSYDragDestinationTextViewDelegate protcol.
-
-
- */
-
 @interface SSYDragDestinationTextView : NSTextView {
-	BOOL _isInDrag ;
-	// BOOL _tabToNextKeyView ; Depracated.  See comments in .m
 }
 
-/*!
- @brief    Sets the ivar _tabToNextKeyView
+@property BOOL activateUponDrop ;
 
- @details  Depracated.  See comments in .m.
- By default, NSTextView accepts hitting the tab key as a text character.
- Setting this to YES tells it to tab to the next key view, like an NSTextField does.
- @param    YES  to tab to the next key view, NO for the default NSTextView behavior.
-- (void)setTabToNextKeyView:(BOOL)yn ;
+/*!
+ @brief    A wrapper around @property fieldEditor, which has a more meaningful
+ name than fieldEditor
+ 
+ @details  You can get the same result in Interface Builder, by switching on the
+ receiver's *Field Editor* checkbox.
  */
+@property BOOL ignoreTabsAndReturns ;
 
 @end
 

Diff for: SSYDragDestinationTextView.m

@@ -1,233 +1,24 @@
 #import "SSYDragDestinationTextView.h"
-#import "NSObject+SuperUtils.h"
-#import "NSView+FocusRing.h"
-#import "SSYDragDestinationTextViewDelegate.h"
-
 
 @implementation SSYDragDestinationTextView : NSTextView
 
-- (void)awakeFromNib {
-	[self patchPreLeopardFocusRingDrawingForScrolling] ;
-	
-	// Safely invoke super
-	[self safelySendSuperSelector:_cmd
-                   prettyFunction:__PRETTY_FUNCTION__
-						arguments:nil] ;
-}
-
-
-/*
- 
-// At one time, I used the following two methods to make the 'tab' and 'shift-tab'
-// keystrokes tab to the next and prior fields instead of being treated as text
-// But then I found a better way: -[NSTextView setFieldEditor:YES].
-// So this code is out.
-
-- (void)setTabToNextKeyView:(BOOL)yn {
-	_tabToNextKeyView = yn ;
+- (void)setIgnoreTabsAndReturns:(BOOL)ignoreTabsAndReturns {
+    [self setFieldEditor:ignoreTabsAndReturns] ;
 }
 
-- (void)keyDown:(NSEvent*)event {
-	NSString *s = [event charactersIgnoringModifiers] ;
-	unichar keyChar = 0 ;
-	if ([s length] == 1) {
-		keyChar = [s characterAtIndex:0] ;
-
-		// Our superclass NSTextView accepts tabs and backtabs as text.
-		// If we want _tabToNextKeyView, we re-implement the NSView behavior
-		// of selecting the next or previous key view
-		if ((keyChar == NSTabCharacter)&& _tabToNextKeyView) {
-			[[self window] selectNextKeyView:self] ;
-		}
-		else if ((keyChar == NSBackTabCharacter) && _tabToNextKeyView) {
-			[[self window] selectPreviousKeyView:self] ;
-		}
-		else {
-			// Handle using super's (i.e. NSTextView) -interpretKeyEvents:,
-			// which will typewrite the key-downed character
-			NSArray* events = [NSArray arrayWithObject:event] ;
-			[self interpretKeyEvents:events] ;
-		}
-	}
+- (BOOL)ignoreTabsAndReturns {
+    return [self isFieldEditor] ;
 }
-*/
 
-- (NSDragOperation)draggingEntered:(id <NSDraggingInfo>)sender {
-	NSDragOperation answer = NSDragOperationNone ;
-	NSPasteboard* pasteboard = [sender draggingPasteboard] ;
-	NSString *anAcceptableType = [pasteboard availableTypeFromArray:[self registeredDraggedTypes]];	
-	
-	if (anAcceptableType != nil) {
-		// Don't be hidden!!!...
-		[NSApp activateIgnoringOtherApps:YES] ;
-		[[self window] makeKeyAndOrderFront:self] ;
-		
-		answer = NSDragOperationCopy ; // Accept data as a copy operation
-		
-		_isInDrag = YES ;
-		[self selectAll:self] ;
-		[self setNeedsDisplay:YES] ;
-	}
-	
-	return answer ;
-}
-
-// Called whenever a drag exits our drop zone
-- (void)draggingExited:(id <NSDraggingInfo>)sender {
-	_isInDrag = NO ;
-	[self setSelectedRange:NSMakeRange(0,0)] ;
-	[self setNeedsDisplay:YES] ;
-}
-
-// Method to determine if we can accept the drop
-- (BOOL)prepareForDragOperation:(id <NSDraggingInfo>)sender {
-	BOOL answer = NO ;
-	
-    NSPasteboard* pasteboard = [sender draggingPasteboard] ;
-    NSArray* registeredTypes = [self registeredDraggedTypes] ;
-    NSString* anAcceptableType = [pasteboard availableTypeFromArray:registeredTypes] ;
-    if (anAcceptableType != nil) {
-        _isInDrag = NO ;
-        [self setSelectedRange:NSMakeRange(0,0)] ;
-        [self setNeedsDisplay:YES] ;
-        answer = YES ;
-    }
-	
-	return answer ;
-} 
-
-// Forward the drop to the delegate, or else, its window's delegate
 - (BOOL)performDragOperation:(id <NSDraggingInfo>)sender {
-    BOOL answer = NO ;
-	if ([self respondsToSelector:@selector(delegate)]) {
-		answer = [(id <SSYDragDestinationTextViewDelegate>)[self delegate] performDragOperation:sender
-										   destination:self] ;
-	}
-	else if ([[[self window] delegate] respondsToSelector:@selector(performDragOperation:destination:)]) {
-		answer = [(id <SSYDragDestinationTextViewDelegate>)[[self window] delegate] performDragOperation:sender
-				  destination:self] ;
-	}
-	
-	return answer ;
-}
+    BOOL didDo = [super performDragOperation:sender] ;
 
-- (void)concludeDragOperation:(id <NSDraggingInfo>)sender {
-}
-
-- (void)drawRect:(NSRect)rect {
-	[super drawRect:rect] ;
-	if (_isInDrag) {
-		[self drawFocusRing] ;
-	}
-}
+    if (self.activateUponDrop) {
+        [NSApp activateIgnoringOtherApps:YES] ;
+        [[self window] makeKeyAndOrderFront:self] ;
+    }
 
-- (void)setString:(NSString *)aString {
-	[super setString:aString] ;
+	return didDo ;
 }
 
-
 @end
-
-/*
-
-	  
-	  NSPasteboard *pb = [sender draggingPasteboard];
- NSString *value;
- NSString *type;
- type = [pb availableTypeFromArray:[NSArray arrayWithObject:NSStringPboardType]];
- if (type) {
- value = [pb stringForType:NSStringPboardType];
- id target = [self myDropTarget];
- SEL action = [self myDropAction];
- [target performSelector:action withObject:value];
- return YES;
- }
- return NO;
- }
-  
- 
- - (BOOL)performDragOperation:(id <NSDraggingInfo>)info {
-	NSPasteboard* pasteboard = [info draggingPasteboard] ;
-	
-	NSArray* acceptableTypes ;
-	if ([self respondsToSelector:@selector(orderedRegisteredDraggedTypes)]) {
-		acceptableTypes = [self orderedRegisteredDraggedTypes] ;
-	}
-	else {
-		acceptableTypes = [self registeredDraggedTypes] ;
-	}
-	NSString *bestType = [pasteboard availableTypeFromArray:acceptableTypes] ;	
-	
-	id object = nil ;
-	
-	if ([bestType isEqualToString:@"MV Super-secret message transfer pasteboard type"]) {
-		NSLog(@"Tried drag of Apple Mail message: not supported yet.") ;
-		//		// Three reasons why this code is commented out:
-		//		// 1.  Import takes 30 seconds or more.
-		//		// 2.  Import comes in html, as shown below.  Must filter to plain text somehow:
-		//		// this:</DIV><DIV><BR></DIV><DIV>Licensee Name:</DIV><DIV>bH New Sale =
-		//		// 150953</DIV><DIV><BR></DIV><DIV>Serial =
-		//		// Number:</DIV><DIV>CbN34wJoOVX7Jgva</DIV><DIV><BR></DIV><DIV>Bookmarksman =		
-		//		// Neither of problems 1 or 2 are fixed by uncommenting "theLock" in
-		//		// CIPAppleScriptHelper.m
-		//		// 3.  According to Apple Documentation, should not use [self class] in the
-		//		// next line but should use [MyApp class] instead.  But MyApp is not
-		//		// declared anywhere.  Maybe this could be fixed by using -classNamed:@"MyApp".
-		//		// But who do you send that instance message to?
-		//		NSBundle *bundle = [NSBundle bundleForClass:[self class]];
-		//		NSLog(@"Hullo!  bundlePath = %@", [bundle bundlePath]) ;
-		//		NSString *resourcePath = [bundle pathForResource: @"MailHelper"
-		//												  ofType: @"applescript"];
-		//		
-		//		NSLog(@"Hullo!  resourcePath = %@", resourcePath) ;
-		//		NSLog(@"Hullo!  1 Getting result from helper") ;
-		//		NSAppleEventDescriptor *result =
-		//			[[CIPAppleScriptHelper sharedHelper] callInResource: resourcePath
-		//														 script: @"getSelectedMailCount"] ;
-		//		
-		//		NSLog(@"Hullo!  1 result = %@", result) ;
-		//		NSMutableString* textFromMessages = [[NSMutableString alloc] init] ;
-		//		
-		//		if(result) {
-		//			int k;
-		//			NSString *mailMessage;
-		//			
-		//			NSLog(@"Hullo!  2 Getting result from helper") ;
-		//			result = [[CIPAppleScriptHelper sharedHelper] callInResource: resourcePath
-		//																  script: @"getSelectedMailBodies"];
-		//			NSLog(@"Hullo!  2 result = %@", result) ;
-		//			int numberOfItems = [result numberOfItems];
-		//			NSLog(@"Hullo!  numberOfItems = %i", numberOfItems) ;
-		//			for(k=1; k <= numberOfItems; k++) {
-		//				mailMessage = [[result descriptorAtIndex: k] stringValue] ;
-		//				NSLog(@"Hullo!  mailMessage = %@", mailMessage) ;
-		//				[textFromMessages appendString:mailMessage] ;
-		//			}		
-		//		}
-		//		
-		//		if ([textFromMessages length] > 0) {
-		//			object = [textFromMessages copy] ;
-		//		}
-		//		
-		//		[textFromMessages release] ;
-		
-	}
-	
-	if (!object) {
-		object = [pasteboard propertyListForType:bestType] ;
-		if (!object) {
-			object = [pasteboard stringForType:bestType] ;
-			if (!object) {
-				object = [pasteboard dataForType:bestType] ;
-			}
-		}
-	}
-	
-	if (object) {
-		[[self target] performSelector:@selector(swallowDraggedObject:) withObject:object] ;
-		return YES ;
-	}
-	
-	return NO ;
-}
-*/