BookMacster 1.17 working good, now making a few changes to better support changes to Safari in Mavericks. This commit contains fixes of memory leaks - woohoo BookMacster seems to be leak-free now, at least when performing all of the common operations. Also this commit has changes to quiet warnings which are new in Xcode 5 after “upgrading project to recommended settings”. One new warning that came up in 150 places is that Xcode 5 wants all selector name referenced in an @selector() directive to be declared in the file or included headers. Indeed, I have created unimplemented selector bugs in the past which would have been caught by this warning. So I spent a few hours adding a lot of #imports and declarations.

Author: jerrykrinock

SSMoveableToolTip.m

@@ -60,8 +60,9 @@ - (id) init {
 }
 
 - (void) dealloc {
-    [_window release];
-    [_textAttributes release];
+    [_window release] ;
+    [_textAttributes release] ;
+    [_textField release] ;  // Memory leak fixed in BookMacster 1.17
 
     [super dealloc];
 }

SSRSS.m

@@ -522,7 +522,10 @@ - (void) normalizeRSSItem: (NSMutableDictionary *) rssItem {
 			title = @"Untitled";	
 	} /*if*/
 
-	[rssItem setObject: title forKey: titleKey];
+	if (title != nil) {
+		
+        [rssItem setObject: title forKey: titleKey];
+	} /*if*/
 
 	/*dangerousmeta case: super-long title with no description*/
 
@@ -578,7 +581,8 @@ - (void) normalizeRSSItem: (NSMutableDictionary *) rssItem {
 				if ([NSString stringIsEmpty: convertedTitle])
 					convertedTitle = @"Untitled";
 
-				[rssItem setObject: convertedTitle forKey: @"convertedTitle"];
+				if (convertedTitle != nil)
+                    [rssItem setObject: convertedTitle forKey: @"convertedTitle"];
 			} /*if*/
 		} /*if*/
 	} /*deal with entities*/

SSYDocChildObject.m

@@ -37,7 +37,6 @@ - (id)initWithDocument:(BkmxDoc*)document_ {
 		[self setDocument:document_] ;
 	}
 
-    /*SSYDBL*/ NSLog(@"Initted %@", self) ;
 	return self;
 }
 

SSYDocFileObserver.m

@@ -112,9 +112,11 @@ - (oneway void)release {
 	// when retainCount==2.
 	if (([self retainCount] == 2) && m_retainedByTimer) {
 		// 
-		m_retainedByTimer = NO ;			
+		m_retainedByTimer = NO ;
+        // The following line has a bug fixed in BookMacster 1.17.  Prior to
+        // that, @selector(analyzePathChange:) was lacking the colon!
 		[NSObject cancelPreviousPerformRequestsWithTarget:self
-												 selector:@selector(analyzePathChange)
+												 selector:@selector(analyzePathChange:)
 												   object:nil] ;
 		// But we don't invoke -dealloc directly.  The above cancellation
 		// will send us a -release (since the timer retains us) which

SSYDragTableView.m

@@ -1,5 +1,6 @@
 #import "SSYDragTableView.h"
 #import "NSInvocation+Quick.h"
+#import "SSYArrayController.h"
 
 
 @implementation SSYDragTableView

SSYDynamicMenu.h

@@ -177,4 +177,6 @@
 */
 - (void)reload ;
 
+- (IBAction)hierarchicalMenuAction:(id)sender  ;
+
 @end

SSYHierarchicalTabViewItem.h

@@ -4,7 +4,6 @@
 
 NSString* const SSYHintArrowDidCloseNotification = @"SSYHintArrowDidCloseNotification" ;
 
-NSString* const SSYHintArrowWillProcessEventNotification = @"SSYHintArrowWillProcessEventNotification" ;
 NSString* const SSYHintArrowEventKey = @"SSYHintArrowEventKey" ;
 
 #define SSYHINTARROW_TOP_COLOR [NSColor colorWithCalibratedRed:(80.0/256.0) green:(111.0/256.0) blue:(246.0/256.0) alpha:1.0]
@@ -189,11 +188,6 @@ - (SSYHintArrow *)initAttachedToPoint:(NSPoint)point
 													 name:NSWindowWillCloseNotification
 												   object:window] ;
 
-		[[NSNotificationCenter defaultCenter] addObserver:self
-												 selector:@selector(didReceiveEvent:)
-													 name:SSYHintArrowWillProcessEventNotification
-												   object:window] ;
-		
         // Configure window
         [super setBackgroundColor:[NSColor clearColor]] ;
         [self setMovableByWindowBackground:NO] ;

SSYHierarchicalTabViewItem.m

@@ -9,5 +9,4 @@ - (void)sendEvent:(NSEvent *)event {
 	[super sendEvent:event] ;
 }
 
-
 @end

SSYHintArrow.m

@@ -85,6 +85,8 @@ + (BOOL)sendHeaderByte:(char)txHeaderByte
 			}
 		}
 	}
+    
+    [aggrRxData release] ;
 
 end:
 	if (!ok && error_p) {

SSYHintableWindow.m

@@ -28,6 +28,10 @@ + (NSArray*)searchKeychainFor:(SecKeychainSearchRef)searchRef
 				getAttributes:(SecKeychainAttributeInfo)attributeInfo {
 	NSArray *output= nil ;
 	NSMutableArray* results = [[NSMutableArray alloc] init] ;
+    // Unbelieveable bug fixed in BookMacster 1.17.  How could this have been
+    // so wrong for so long?  Prior to this, returnArrayOfDics was determined
+    // by the count of attributeList instead of attributeInfo.
+    BOOL returnArrayOfDics = (attributeInfo.count > 1) ;
 	OSStatus status = noErr ;
 	while (status == noErr) {
 		SecKeychainItemRef itemRef = NULL ;
@@ -50,7 +54,7 @@ + (NSArray*)searchKeychainFor:(SecKeychainSearchRef)searchRef
 																		NULL) ;
 			if (attrResult == noErr) {
 				NSMutableDictionary* itemDic = nil ;
-				if (attributeList->count > 1) {
+				if (returnArrayOfDics) {
 					itemDic = [[NSMutableDictionary alloc] init] ;
 				}
 
@@ -65,7 +69,7 @@ + (NSArray*)searchKeychainFor:(SecKeychainSearchRef)searchRef
 															   attribute->length,
 															   kCFStringEncodingUTF8,
 															   false) ;
-					if (attributeList->count > 1) {
+					if (returnArrayOfDics) {
 						[itemDic setObject:value
 									forKey:[NSNumber numberWithInteger:(attribute->tag)]] ;
 					}
@@ -76,7 +80,7 @@ + (NSArray*)searchKeychainFor:(SecKeychainSearchRef)searchRef
 				}
 				SecKeychainItemFreeAttributesAndData(attributeList, NULL) ;
 
-				if (attributeList->count > 1) {
+				if (returnArrayOfDics) {
 					[results addObject:[NSDictionary dictionaryWithDictionary:itemDic]] ;
 				}
 
@@ -87,8 +91,7 @@ + (NSArray*)searchKeychainFor:(SecKeychainSearchRef)searchRef
 
 	output = [[results copy] autorelease] ;
 	[results release] ;
-	
-	return output;
+	return output ;
 }
 
 + (NSArray*)allGenericItems {	
@@ -205,7 +208,7 @@ + (NSArray*)internetAccountsForHost:(NSString*)host {
 
 		output = [self searchKeychainFor:searchRef
 						   getAttributes:attributeInfo] ;
-	}
+  	}
 
 	if (searchRef) {
 		CFRelease(searchRef) ;

SSYInterappClient.m

@@ -1,12 +1,27 @@
 #import <Cocoa/Cocoa.h>
 
+extern NSString* SSYLazyViewErrorDomain ;
+
+#define SSY_LAZY_VIEW_ERROR_CODE_COULD_NOT_LOAD_NIB        992611
+#define SSY_LAZY_VIEW_ERROR_CODE_LEGACY_COULD_NOT_LOAD_NIB 992613
+#define SSY_LAZY_VIEW_ERROR_CODE_LEGACY_COULD_NOT_FIND_NIB 992614
+#define SSY_LAZY_VIEW_ERROR_CODE_NO_PAYLOAD                992616
+
 /*
- @brief    Notification which is posted when the payload view loads.
+ @brief    Notification which is posted when the payload view is about to be
+ loaded.
  
  @details  The notification object is the window in which the SSYLazyView object
- resides.  Note that the
- loading of the payload, and hence the posting of this notification, occurs no
- more than once during the lifetime of an SSYLazyView object.
+ resides.  Note that the loading of the payload, and hence the posting of this
+ notification, occurs no more than once during the lifetime of an SSYLazyView
+ object.
+ */
+extern NSString* SSYLazyViewWillLoadPayloadNotification;
+
+/*
+ @brief    Notification which is posted after the payload view loads.
+ 
+ @details  Ditto from SSYLazyViewWillLoadPayloadNotification.
  */
 extern NSString* SSYLazyViewDidLoadPayloadNotification;
 
@@ -39,6 +54,13 @@ extern NSString* SSYLazyViewDidLoadPayloadNotification;
  in your Lazy View.  For example, you may place a text field with large
  font size that says "Loading Stuff…".  All of these placeholder subviews
  will be removed when the new view is placed in.
+
+ If an error occurs when attempting to load the payload, in either case (when
+ receiver is moved to a window or upon -loadWithOwner:), an error dialog
+ suggesting that the user reinstall the application is displayed.  We did this
+ because these errors should occur very rarely, and in the first case, there
+ is no message for us to return an error in.  Yeah, we could have used a 
+ delegate or something, but it's not worth the effort.
  */
 @interface SSYLazyView : NSView {
     BOOL m_isPayloaded ;