Removed method -[SSYOtherApper majorVersionOfBundlePath:] because you can use class methods in SSYVersionTriplet which are better.

Author: jerrykrinock

SSYOtherApper.h

@@ -1,5 +1,7 @@
 #import <Cocoa/Cocoa.h>
 
+#import "SSYVersionTriplet.h"
+
 extern NSString* const SSYOtherApperErrorDomain ;
 
 extern NSString* const SSYOtherApperKeyPid ;
@@ -146,24 +148,6 @@ __attribute__((visibility("default"))) @interface SSYOtherApper : NSObject {}
 */
 + (SSYOtherApperProcessState)stateOfPid:(pid_t)pid ;
 
-/*!
- @brief    Returns the major version which is believed to be the version of the
- package at a given bundle path, or 0 if no such version could be found
- 
- @result   First, tries to parse the answer from 
- of the given
- bundlePath, and if that fails tries CFBundleVersion.  Usually the former is the one
- you want.  For example, today I find…
- 
-               CFBundleShortVersionString     CFBundleVersion
-               --------------------------     ---------------
- *  Firefox    23.0a2                         2313.5.17
- *   Safari    6.0.5                          8536.30.1
- 
- Given the above Info.plists, this method would return 23 for Firefox and 6 for Safari.
- */
-+ (NSInteger)majorVersionOfBundlePath:(NSString*)bundlePath ;
-
 /*!
  @brief    Returns the unix process ID (pid) of any process whose last path
  component matches a given process name, and whose user id is the same

SSYOtherApper.m

@@ -437,60 +437,6 @@ + (SSYOtherApperProcessState)stateOfPid:(pid_t)pid {
     return processState ;
 }
 
-+ (NSInteger)majorVersionOfBundlePath:(NSString*)bundlePath {
-	NSString* infoPlistPath = [bundlePath stringByAppendingPathComponent:@"Contents"] ;
-	infoPlistPath = [infoPlistPath stringByAppendingPathComponent:@"Info.plist"] ;
-	NSData* data = [NSData dataWithContentsOfFile:infoPlistPath] ;
-	NSDictionary* infoDic = nil ;
-    if (data) {
-        NSError* error = nil ;
-        infoDic = [NSPropertyListSerialization propertyListWithData:data
-                                                            options:NSPropertyListImmutable
-                                                             format:NULL
-                                                              error:&error] ;
-        // Documentation of this method is vague, but it appears to be
-        // better to check for error != nil than infoDic == nil.
-        if (error) {
-            NSLog(@"Internal Error 425-2349 %@", error) ;
-        }
-    }
-    
-	NSString* string ;
-	NSInteger majorVersion ;
-	if (infoDic) {
-		string = [infoDic objectForKey:@"CFBundleShortVersionString"] ;
-		majorVersion = [string majorVersion] ;
-		
-		if (majorVersion == 0) {
-			string = [infoDic objectForKey:@"CFBundleVersion"] ;
-			majorVersion = [string majorVersion] ;
-		}
-	}
-	else {
-		// This scheme was the only one used until BookMacster 1.6.5.
-		// It was found that this gives an outdated answer when Firefox is updated,
-		// until Firefox was launched and quit again.
-		// This is due to the same bug that plagues Path Finder.
-		// Actually, the bug is documented, in +[NSBundle bundleWithPath],
-		// "This method allocates and initializes the returned object if there is no
-		// existing NSBundle associated with fullPath, in which case it returns the
-		// existing object" (which, if bundlePath has been updated since this
-		// app launched, is going to be the old bundle).  So now we only
-		// use this scheme if all else has failed.
-		NSBundle* bundle = [NSBundle bundleWithPath:bundlePath] ;
-		
-		string = [bundle objectForInfoDictionaryKey:@"CFBundleVersion"] ;
-		majorVersion = [string majorVersion] ;
-		
-		if (majorVersion == 0) {
-			string = [bundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"] ;
-			majorVersion = [string majorVersion] ;
-		}
-	}
-
-	return majorVersion ;
-}
-
 + (pid_t)pidOfProcessNamed:(NSString*)processName
 					  user:(NSString*)user {
 	NSArray* infos = [self pidsExecutablesFull:NO] ;
@@ -932,7 +878,7 @@ + (void)killProcessPID:(pid_t)pid
 */
 
 /* The following two methods, written during different years, could be
- refactored to use some commone code, if one would want to do the testing. */
+ refactored to use some common code, if one would want to do the testing. */
 
 + (BOOL)killThisUsersProcessWithPid:(pid_t)pid
                                 sig:(int)sig