• Fixed a few memory leaks and other new warnings issued by static analyzer after updating to Xcode 8.

Author: jerrykrinock

SSYAlert.m

@@ -2502,12 +2502,14 @@ - (void)dealloc {
 	[progressBar release] ;
 	[titleTextView release] ;
 	[smallTextView release] ;
+    [smallTextScrollView release] ;
 	[helpButton release] ;
 	[supportButton release] ;
 	[checkbox release] ;
 	[button1 release] ;
 	[button2 release] ;
 	[button3 release] ;
+    [button4 release] ;
 	[helpAnchorString release] ;
 	[errorPresenting release] ;
 	[iconInformational release] ;

SSYDeallocDetector.h

@@ -8,7 +8,6 @@
  @details  We leave the usage of this class to your imagination!
 */
 @interface SSYDeallocDetector : NSObject {
-	NSInvocation* m_invocation ;
 }
 
 @property (retain) NSInvocation* invocation ;

SSYDeallocDetector.m

@@ -3,9 +3,6 @@
 
 @implementation SSYDeallocDetector
 
-@synthesize invocation = m_invocation ;
-@synthesize logMsg = m_logMsg ;
-
 #if 0
 #warning  Logging R&R of Dealloc Detector
 - (id)retain {
@@ -20,13 +17,13 @@ - (oneway void)release {
 #endif
 
 - (void)dealloc {
-	[[self invocation] invoke] ;
-	[m_invocation release] ;
+	[_invocation invoke] ;
 
-    if (m_logMsg) {
-        NSLog(@"Deallocced %p %@", (__bridge void*)self, m_logMsg) ;
+    [_invocation release] ;
+    if (_logMsg) {
+        NSLog(@"Deallocced %p %@", (__bridge void*)self, _logMsg) ;
     }
-    [m_logMsg release] ;
+    [_logMsg release] ;
 
 	[super dealloc] ;
 }
@@ -52,4 +49,4 @@ + (SSYDeallocDetector*)detectorWithInvocation:(NSInvocation*)invocation
 	return [instance autorelease] ;
 }
 
-@end
+@end

SSYHintArrow.m

@@ -17,8 +17,7 @@ @implementation SSYHintArrow
 # pragma mark * Heavy Lifters
 
 - (CGFloat)scaleFactor {
-    // Was using deprecated [NSScreen mainScreen] userSpaceScaleFactor]
-    CGFloat factor = [[self contentView] backingScaleFactor] ;
+    CGFloat factor = 1.0 ;
     return factor ;
 }
 
@@ -349,4 +348,4 @@ + (void)removeIfEvent:(NSEvent*)event {
 	}
 }
 
-@end
+@end

SSYLabelledList.m

@@ -271,7 +271,7 @@ - (NSString *)tableView:(NSTableView*)tableView
 		  mouseLocation:(NSPoint)mouseLocation {
 	id toolTip = [[self toolTips] objectAtIndex:rowIndex] ;
 	if (![toolTip isKindOfClass:[NSString class]]) {
-		toolTip = nil ;
+		toolTip = @"" ;
 	}
 
 	return toolTip ;

SSYLabelledRadioButtons.m

@@ -215,7 +215,7 @@ - (id)initWithLabel:(NSString*)label
 		// If used, the label text field is added last.
 		// We assume this order when accessing the subviews later.
 
-		NSButtonCell* cell = [[NSButtonCell alloc] initTextCell:@"proto"] ;
+		NSButtonCell* cell = [[NSButtonCell alloc] initTextCell:NSLocalizedString(@"proto", nil)] ;
 		[cell setButtonType:NSRadioButton] ;
 		[cell setTitle:@""] ;
 		NSMatrix* matrix  = [[NSMatrix alloc] initWithFrame:NSZeroRect
@@ -329,4 +329,4 @@ - (id)initWithCoder:(NSCoder *)coder {
 	return self ;
 }
 
-@end
+@end

SSYLinearFileWriter.m

@@ -70,5 +70,11 @@ + (void)close {
 	[[SSYLinearFileWriter sharedFileWriter] setFileHandle:nil] ;
 }
 
+- (void)dealloc {
+    [m_fileHandle release] ;
+    
+    [super dealloc] ;
+}
+
 @end
 

SSYPrefsWindowController.m

@@ -39,11 +39,11 @@ -(void)	dealloc {
 
 
 -(void)	awakeFromNib {
-	NSString*		key;
 	NSInteger		index = 0;
 	NSString*		wndTitle = nil;
 
-	[[self window] setTitle:[self localizeString:@"windowTitlePrefs"]] ;
+    NSString* title = NSLocalizedString(@"Preferences", nil) ;
+    [[self window] setTitle:title] ;
 
 	// Generate a string containing the window's title so we can display the original window title plus the selected pane:
 	wndTitle = [[ibOutlet_tabView window] title];
@@ -55,7 +55,7 @@ -(void)	awakeFromNib {
 	[[self window] setFrameAutosaveName:@"PrefsWindow"] ; 
 
 	// Select the preferences page the user last had selected when this window was opened:
-	key = [NSString stringWithFormat: @"%@.prefspanel.recentTab", @"PrefsWindow"];
+	NSString* key = [NSString stringWithFormat: @"%@.prefspanel.recentTab", @"PrefsWindow"];
 	index = [[NSUserDefaults standardUserDefaults] integerForKey:key];
 	[ibOutlet_tabView selectTabViewItemAtIndex:index];
 
@@ -325,4 +325,4 @@ - (NSString*)localizeString:(NSString*)key {
 }
 
 
-@end
+@end

SSYStarRatingView.m

@@ -85,6 +85,7 @@ -(void)dealloc
     [m_starHighlightedImage release] ;
     [m_removeXImage release] ;
     [m_backgroundColor release] ;
+    [m_rating release] ;
 
 	[super dealloc] ;
 }
@@ -276,4 +277,4 @@ -(void)mouseUp:(NSEvent *)theEvent
         [[self delegate] starsSelectionChanged:self rating:[[self rating] floatValue]];
 }
 
-@end
+@end