Skip to content

Commit 9af53ff

Browse files
committed
Show/upload test results even when ESLint step fails
1 parent 817204e commit 9af53ff

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/security.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ jobs:
2626
run: npm ci --no-fund
2727
- name: Run ESLint
2828
run: npm run security:eslint
29-
continue-on-error: true
3029
- name: Upload analysis results to GitHub
3130
uses: github/codeql-action/upload-sarif@v2
31+
if: success() || failure() # Run this step even if previous step failed.
3232
with:
3333
sarif_file: eslint-results.sarif
3434
wait-for-processing: true
@@ -66,6 +66,7 @@ jobs:
6666
run: npm run test
6767
- name: SonarCloud Scan
6868
uses: SonarSource/[email protected]
69+
if: success() || failure() # Run this step even if previous step failed.
6970
env:
7071
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7172
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
@@ -91,3 +92,4 @@ jobs:
9192
run: npm run test
9293
- name: Upload coverage to Codecov
9394
uses: codecov/codecov-action@v3
95+
if: success() || failure() # Run this step even if previous step failed.

0 commit comments

Comments
 (0)