Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make worker path optional #7

Closed
jerch opened this issue May 2, 2022 · 3 comments · Fixed by #36
Closed

make worker path optional #7

jerch opened this issue May 2, 2022 · 3 comments · Fixed by #36

Comments

@jerch
Copy link
Owner

jerch commented May 2, 2022

No description provided.

@jerch
Copy link
Owner Author

jerch commented May 3, 2022

Postponed, as it is quite involved to get done right (might need some sort of preprocessor logic, which typescript lacks). Also see different build targets in node-sixel.

@jerch
Copy link
Owner Author

jerch commented May 3, 2022

Also check for obvious perf smells in #1 (comment).

@jerch
Copy link
Owner Author

jerch commented Aug 25, 2022

The current worker approach with a distributed ready-to-go worker file furthermore creates some frictions in projects, how to add the worker asset conveniently. Needs some investigations about proper worker file bundling, maybe we can provide an easier to digest asset, which does not collide with package versioning/bundling setups.

@jerch jerch mentioned this issue Sep 17, 2022
2 tasks
@jerch jerch closed this as completed in #36 Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant