From 6b27303884f982733601b168913916d0b4acc001 Mon Sep 17 00:00:00 2001 From: Vincent Latombe Date: Fri, 10 Jan 2025 17:26:57 +0100 Subject: [PATCH] In case of a large FlowExecutionList, logging everything to warning level is too verbose Only log the details if there is actually FINE level enabled. --- .../jenkinsci/plugins/workflow/flow/FlowExecutionList.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java b/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java index 696f62c5..ee2fa48a 100644 --- a/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java +++ b/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java @@ -308,7 +308,12 @@ public void onSuccess(@NonNull List result) { FlowExecutionList list = FlowExecutionList.get(); FlowExecutionOwner owner = e.getOwner(); if (!list.runningTasks.contains(owner)) { - LOGGER.log(Level.WARNING, "Resuming {0}, which is missing from FlowExecutionList ({1}), so registering it now.", new Object[] {owner, list.runningTasks.getView()}); + if (LOGGER.isLoggable(Level.FINE)) { + // Still a warning, but give more details for debugging + LOGGER.log(Level.WARNING, () -> "Resuming " + owner + ", which is missing from FlowExecutionList (" + list.runningTasks.getView() + "), so registering it now."); + } else { + LOGGER.log(Level.WARNING, () -> "Resuming " + owner + ", which is missing from FlowExecutionList, so registering it now."); + } list.register(owner); } LOGGER.log(Level.FINE, "Will resume {0}", result);