[JENKINS-45157] [WIP] PCT should be able to exercise declarative pipeline plugins#35
[JENKINS-45157] [WIP] PCT should be able to exercise declarative pipeline plugins#35raul-arabaolaza wants to merge 2 commits intojenkinsci:masterfrom
Conversation
|
🐝 Let's wait to merge #34 and then we'll merge this one. This looks fine from an implementation perspective. |
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Seems plugin-compat-tester is just going from bad to worse with special-case hooks. I hope jenkinsci/maven-hpi-plugin#66 could provide a more maintainable solution going forward.
| PomData pomData = (PomData)info.get("pomData"); | ||
| MavenCoordinates parent = pomData.parent; | ||
| MavenCoordinates coreCoordinates = (MavenCoordinates)info.get("coreCoordinates"); | ||
| boolean isDeclarartivePipeline = parent.matches("org.jenkinsci.plugins", "pipeline-model-parent"); |
|
@jglick In fact I am not trying more profound fixes or refactorings
because AFAIK you are working in a new approach.
2017-06-28 21:41 GMT+02:00 Jesse Glick <[email protected]>:
… ***@***.**** commented on this pull request.
Seems plugin-compat-tester is just going from bad to worse with
special-case hooks. I hope jenkinsci/maven-hpi-plugin#66
<jenkinsci/maven-hpi-plugin#66> could provide a
more maintainable solution going forward.
------------------------------
In plugins-compat-tester/src/main/java/org/jenkins/tools/
test/hook/TransformPom.java
<#35 (comment)>
:
> @@ -25,6 +25,7 @@ public boolean check(Map<String, Object> info) {
PomData pomData = (PomData)info.get("pomData");
MavenCoordinates parent = pomData.parent;
MavenCoordinates coreCoordinates = (MavenCoordinates)info.get("coreCoordinates");
+ boolean isDeclarartivePipeline = parent.matches("org.jenkinsci.plugins", "pipeline-model-parent");
Typo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnN48WibvhnJivDrhGcY-UeB-n0UjnZks5sIqxRgaJpZM4OGsUz>
.
|
|
Right, my hope is that we will able to run something along the lines of git clone https://github.com/jenkinsci/pipeline-model-definition-plugin
mvn -f pipeline-model-definition-plugin -DoverrideVersions=org.jenkins-ci.main:jenkins-core:2.60.1,org.jenkins-ci.main:jenkins-war:2.60.1,org.jenkins-ci.plugins:branch-api:2.0,… -DuseUpperBounds=true clean install(to run all tests in all modules in that reactor using updated dependencies) but the concept is not yet proven. |
|
@jglick That sounds cool given that is able to deal with different types of dependencies (optional, transitive) , scopes and classifiers. Also the list of dependencies can be large and generate it manually can be very error prone. So I would suggest implementing a mechanism similar to |
|
Why closed? |
3 participants
JENKINS-45157
Same approach as used in #34
@reviewbybees specially @varyvol and @kwhetstone